Bug 212564 - www/nspluginwrapper => ELF file OS ABI invalid
Summary: www/nspluginwrapper => ELF file OS ABI invalid
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-10 18:07 UTC by Walter Schwarzenfeld
Modified: 2016-09-11 14:36 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (jkim)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Walter Schwarzenfeld freebsd_triage 2016-09-10 18:07:20 UTC 
nspluginwrapper -v -a -i  gives:

*** NSPlugin Viewer  *** ERROR: /usr/local/lib/browser_plugins/linux-c6-flashplugin/libflashplayer.so: ELF file OS ABI invalid
*** NSPlugin Viewer  *** ERROR: /usr/local/lib/browser_plugins/linux-c6-flashplugin/libflashplayer.so: ELF file OS ABI invalid
Auto-install plugins from /usr/local/lib/browser_plugins/symlinks/linux-firefox
Looking for plugins in /usr/local/lib/browser_plugins/symlinks/linux-firefox
*** NSPlugin Viewer  *** ERROR: /usr/local/lib/browser_plugins/symlinks/linux-firefox/libflashplayer.so: ELF file OS ABI invalid
*** NSPlugin Viewer  *** ERROR: /usr/local/lib/browser_plugins/symlinks/linux-firefox/libflashplayer.so: ELF file OS ABI invalid

works as expected with
nspluginwrapper -v -a -u
Comment 1 Walter Schwarzenfeld freebsd_triage 2016-09-10 18:08:57 UTC 
also see:
https://forums.freebsd.org/threads/57612/
Comment 2 Walter Schwarzenfeld freebsd_triage 2016-09-10 18:25:47 UTC 
Last statement was wrong. 
nspluginwrapper -v -a -u runs without error messages.

But I don't see the flashplugin in the plugins-tab of firefox. Maybe, it has to do with the firefox update, CC Ffirefox maintainer.
Comment 3 Walter Schwarzenfeld freebsd_triage 2016-09-10 18:41:31 UTC 
reinstall of linux-c6-flashplugin says:
(linux-c6-flashplugin-11.2r202.632_2) /ram/usr/ports/www/linux-c6-flashplugin11/work/stage//usr/local/bin/flash-player-properties - required shared library libm.so.6 not found
(linux-c6-flashplugin-11.2r202.632_2) /ram/usr/ports/www/linux-c6-flashplugin11/work/stage//usr/local/bin/flash-player-properties - required shared library ld-linux.so.2 not found
(linux-c6-flashplugin-11.2r202.632_2) /ram/usr/ports/www/linux-c6-flashplugin11/work/stage//usr/local/bin/flash-player-properties - required shared library libdl.so.2 not found
Comment 4 Jan Beich freebsd_committer freebsd_triage 2016-09-10 21:43:28 UTC 
Do native plugins work? Try bisecting emulators/linux_base-c6 changes in a pristine jail. NPAPI in Firefox isn't going away until 53.0.
Comment 5 Walter Schwarzenfeld freebsd_triage 2016-09-10 21:52:39 UTC 
All other addons and plugins seems work "normal" (iced-tea...). But flash is not there.
I post it cause of the forum-thread.
But we should be happy, flash was a annoying thing ;-)).
Comment 6 Tijl Coosemans freebsd_committer freebsd_triage 2016-09-11 09:58:20 UTC 
The plugin works fine here.  Can you post the output of these commands:

file /usr/local/lib/browser_plugins/linux-c6-flashplugin/libflashplayer.so
/compat/linux/bin/sh ldd /usr/local/lib/browser_plugins/linux-c6-flashplugin/libflashplayer.so
Comment 7 Walter Schwarzenfeld freebsd_triage 2016-09-11 13:13:58 UTC 
1) file /usr/local/lib/browser_plugins/linux-c6-flashplugin/libflashplayer.so

/usr/local/lib/browser_plugins/linux-c6-flashplugin/libflashplayer.so: ELF 32-bit LSB shared object, Intel 80386, version 1 (FreeBSD), dynamically linked, stripped

2) /compat/linux/bin/sh ldd /usr/local/lib/browser_plugins/linux-c6-flashplugin/libflashplayer.so
/usr/bin/ldd: line 116: /dev/null: Permission denied
ldd: warning: you do not have execution permission for `/usr/local/lib/browser_plugins/linux-c6-flashplugin/libflashplayer.so'
	not a dynamic executable
Comment 8 Warren Block freebsd_committer freebsd_triage 2016-09-11 13:15:26 UTC 
Seeing the same problem here, with the exact same output for file and ldd as shown in comment #7.
Comment 9 Tijl Coosemans freebsd_committer freebsd_triage 2016-09-11 13:51:39 UTC 
(In reply to w.schwarzenfeld from comment #7)
> /usr/local/lib/browser_plugins/linux-c6-flashplugin/libflashplayer.so:
> ELF 32-bit LSB shared object, Intel 80386, version 1 (FreeBSD),
> dynamically linked, stripped

This is obviously wrong.  It's not a FreeBSD file.  An immediate fix would be to run "brandelf -t Linux /usr/local/lib/browser_plugins/linux-c6-flashplugin/libflashplayer.so" and probably also "brandelf -t Linux /compat/linux/usr/lib/libflashsupport.so".  I suspect this may be caused by strip on FreeBSD 10 and older.  What is the output of "strip --version"?
Comment 10 Walter Schwarzenfeld freebsd_triage 2016-09-11 13:58:32 UTC 
 strip --version
GNU strip 2.17.50 [FreeBSD] 2007-07-03
Comment 11 commit-hook freebsd_committer freebsd_triage 2016-09-11 14:14:53 UTC 
A commit references this bug:

Author: tijl
Date: Sun Sep 11 14:14:50 UTC 2016
New revision: 421821
URL: https://svnweb.freebsd.org/changeset/ports/421821

Log:
  Set STRIP= so INSTALL_LIB doesn't call strip(1) which in the case of GNU
  strip brands the library as a FreeBSD library.

  PR:		212564

Changes:
  head/www/linux-c6-flashplugin11/Makefile
  head/www/linux-c6-flashplugin11/pkg-plist
Comment 12 Tijl Coosemans freebsd_committer freebsd_triage 2016-09-11 14:18:17 UTC 
The above commit should fix it.  Please test.
Comment 13 Walter Schwarzenfeld freebsd_triage 2016-09-11 14:34:00 UTC 
Yes, this works. Thanks!