Created attachment 174820 [details] Oniguruma version 6.1.1 Port Goals: 1: Track Oniguruma's regular expressions library version 6. 2: Start moving all FreeBSD ports that use oniguruma4 and oniguruma5 to oniguruma6. There are only a handful of ports that use oniguruma so this is not a large task. 3: I tested port php70 with oniguruma6. The port built without issues and php70 used mb_ereg without issues. 4: Use github.com tags to track versions. Port Request: 1: Add myself to be a MAINTAINER.
Created attachment 177617 [details] same patch for 6.1.2
One addition in 6.1.2: Added the 'test' target.
Created attachment 177619 [details] same patch for 6.1.2 Simplified Makefile.
@Yuri Setting TEST_TARGET=test and TEST_WRKSRC=${WRKSRC}/test should be all that's required to run the tests in this case. @Robert are you happy with Yuri's update?
(In reply to Kubilay Kocak from comment #4) The patch looks good.... I'm not home right now so I can't test Yuri's patch now. Let me test the patch in the morning and I'll ping both of you. Thanks for helping me on this patch Yuri and Kubilay.
Created attachment 177681 [details] Same patch against 3.8.1 * Changed the test target as per Kubilay's suggestion. * Changed line order to make porltint happy. Another thing to consider is to name it without the version number: devel/oniguruma Yuri
List of dependent ports: * devel/libslang2 * textproc/jq * mail/sylpheed * lang/php56 * lang/php70 * lang/mosh * japanese/jd But they don't need to be updated immediately since they depend on oniguruma5.
Robert, Did you have a chance to test it? Yuri
Please consider renaming it to just devel/oniguruma.
In my opinion the name change will need maintainer approval. Yuri, if you are willing to list yourself as MAINTAINER, I can proceed with port name change. Otherwise I will be happy to commit this as devel/onigurama6 and you can create a new issue to rename it.
Okay, list me as a maintainer.
This doesn't need to be permanent. I can switch it back to Robert if he asks.
Okay. List me as in other ports (like qTox).
Created attachment 178154 [details] devel/onigurama: new port Can you double-check this and let me know if it looks okay?
poudriere testport is good
yes, looks good.
I received some feedback on this so far. 1) DIST_SUBDIR should be put back as "ruby" 2) CONFLICTS line should be adjusted to use CONFLICTS_INSTALL and match current versions of oniguruma (4 and 5) 3) pkg-message should be trimmed to show maybe just the first paragraph and WWW. License, changelog, and attribution information should not be in pkg-message and it's a good idea to keep it under 24 lines in general. I will try to reach out to Robert out of band to see if I can get his feedback too.
I agree with 2) and 3). I only don't see the reason for 1), ruby uses it along with many others. Why have "ruby" in the port?
OK. I took a look at it and I agree with you on #1.
I got more feedback and I will commit this as devel/oniguruma6 for now and if you still would like to maintain it and rename it, we can do it as a separate issue.
A commit references this bug: Author: lifanov Date: Thu Dec 22 15:14:05 UTC 2016 New revision: 429161 URL: https://svnweb.freebsd.org/changeset/ports/429161 Log: new port: devel/oniguruma6 Oniguruma is a regular expressions library. The characteristics of this library is that different character encoding for every regular expression object can be specified. PR: 212715 Submitted by: yuri@rawbw.com, rob@theseusnetworking.com (earlier version) Reviewed by: matthew Approved by: matthew (mentor) Differential Revision: https://reviews.freebsd.org/D8871 Changes: head/devel/Makefile head/devel/oniguruma6/ head/devel/oniguruma6/Makefile head/devel/oniguruma6/distinfo head/devel/oniguruma6/pkg-descr head/devel/oniguruma6/pkg-plist
Committed, thanks!