Bug 213314 - devel/py-singledispatch: Missing dependency: devel/py-six
Summary: devel/py-singledispatch: Missing dependency: devel/py-six
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kubilay Kocak
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2016-10-08 20:12 UTC by Kyle Evans
Modified: 2016-10-09 11:18 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback+
koobs: merge-quarterly+

Attachments
Unified diff of devel/py-singledispatch adding devel/py-six dependency (648 bytes, patch)
2016-10-08 20:12 UTC, Kyle Evans 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer freebsd_triage 2016-10-08 20:12:55 UTC 
Created attachment 175536 [details]
Unified diff of devel/py-singledispatch adding devel/py-six dependency

Hello!

Discovered recently that devel/py-singledispatch is missing the devel/py-six dependency. This could be confirmed by `grep -i install_requires setup.py` inside the $WRKSRC for this port.

I'm attaching the patch I've been using to address this.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-10-09 10:19:35 UTC 
Thank you for your report Kyle
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-10-09 11:12:35 UTC 
A commit references this bug:

Author: koobs
Date: Sun Oct  9 11:12:28 UTC 2016
New revision: 423588
URL: https://svnweb.freebsd.org/changeset/ports/423588

Log:
  devel/py-singledispatch: Add missing dependency (six)

  - Add missing RUN_DEPENDS on six [1]
  - Canonicalize, clarify COMMENT
  - Limit USE_PYTHON version to <= 3.3 (Unnecessary in 3.4+)
  - Enable architecture independence (NO_ARCH)
  - Enable concurrent Python installation

  PR:		213314 [1]
  Submitted by:	Kyle Evans <bsdports kyle-evans net> [1]
  Approved by:	python (maintainer)
  MFH:		2016Q4

Changes:
  head/devel/py-singledispatch/Makefile
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-10-09 11:16:37 UTC 
A commit references this bug:

Author: koobs
Date: Sun Oct  9 11:15:58 UTC 2016
New revision: 423589
URL: https://svnweb.freebsd.org/changeset/ports/423589

Log:
  MFH: r423588: devel/py-singledispatch: Add missing dependency (six)

  - Add missing RUN_DEPENDS on six [1]
  - Canonicalize, clarify COMMENT
  - Limit USE_PYTHON version to <= 3.3 (Unnecessary in 3.4+)
  - Enable architecture independence (NO_ARCH)
  - Enable concurrent Python installation

  PR:		213314 [1]
  Submitted by:	Kyle Evans <bsdports kyle-evans net> [1]
  Approved by:	python (maintainer)

  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2016Q4/
  branches/2016Q4/devel/py-singledispatch/Makefile
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2016-10-09 11:18:35 UTC 
Committed and merged with infrastructure, compliance and/or modernization changes.

Thanks Kyle!