Bug 213349 - net/netatalk3: installation problem due pam config missing in files
Summary: net/netatalk3: installation problem due pam config missing in files
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-10 01:05 UTC by nick.rozhkov
Modified: 2016-10-18 17:47 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback?
koobs: merge-quarterly?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description nick.rozhkov 2016-10-10 01:05:45 UTC 
install  -m 555 /usr/ports/net/netatalk3/work/netatalk-3.1.10/contrib/macusers/macusers  /usr/ports/net/netatalk3/work/stage/usr/local/bin/macusers
install  -m 0644 /usr/ports/net/netatalk3/files/netatalk  /usr/ports/net/netatalk3/work/stage/usr/local/etc/pam.d/netatalk
install: /usr/ports/net/netatalk3/files/netatalk: No such file or directory
*** Error code 71

Stop.
make[1]: stopped in /usr/ports/net/netatalk3
*** Error code 1

Stop.
make: stopped in /usr/ports/net/netatalk3
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2016-10-10 03:47:51 UTC 
Fixed in the latest commit.
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-10-10 03:47:55 UTC 
A commit references this bug:

Author: marcus
Date: Mon Oct 10 03:46:59 UTC 2016
New revision: 423633
URL: https://svnweb.freebsd.org/changeset/ports/423633

Log:
  * Fix PAM installation [1]
  * Fix build with mDNSResponder [2]

  PR:		213349 [1]
  		213350 [2]

Changes:
  head/net/netatalk3/Makefile
  head/net/netatalk3/files/netatalk.pam
  head/net/netatalk3/pkg-message
Comment 3 nick.rozhkov 2016-10-10 12:55:15 UTC 
Many thanks for quick fix& Just checked it but netatalk.pam should contain:

#%PAM-1.0
auth     include system
account  include system
password include system
session  include system

Because the user can't get access to shares with his unix account in case when content of pam:
netatalk        auth    required        pam_unix.so     try_first_pass
netatalk        account required        pam_unix.so     try_first_pass
netatalk        session required        pam_permit.so
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2016-10-10 13:00:31 UTC 
Assign to maintainer and correctly set summary (which would have ensured the former).

Also, revision 423633 (see comment 2)  and any subsequent commit after re-opening (comment 3)  should be MFH'd to the latest quarterly branch
Comment 5 Mark Felder freebsd_committer freebsd_triage 2016-10-18 17:42:14 UTC 
Not sure how ports-secteam was added to this, but I have a proper fix. There was a rollback due to concerns of overwriting PAM configs, but PAM option must certainly have been broken as pkg-plist was not altered to remove it.

By using @sample it will avoid overwriting anyone's custom pam config.
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-10-18 17:46:11 UTC 
A commit references this bug:

Author: feld
Date: Tue Oct 18 17:45:48 UTC 2016
New revision: 424189
URL: https://svnweb.freebsd.org/changeset/ports/424189

Log:
  net/netatalk3: Fix PAM option

  Previous rollback of PAM changes didn't update pkg-plist, so the PAM
  option was broken.

  By using @sample if PAM option is enabled we can install a default PAM
  config that inherits the system PAM configuration while allowing custom
  configs to remain untouched.

  PR:		213349
  MFH:		2016Q4

Changes:
  head/net/netatalk3/Makefile
  head/net/netatalk3/files/pam.conf
  head/net/netatalk3/pkg-message
  head/net/netatalk3/pkg-plist
Comment 7 Mark Felder freebsd_committer freebsd_triage 2016-10-18 17:47:39 UTC 
I'm actually going to cancel the MFH to 2016Q4 as this version wasn't in quarterly.