Created attachment 175597 [details] patch from a git commit Bump to the latest upstream release. https://github.com/boto/s3transfer/blob/0.1.7/CHANGELOG.rst
portlint: OK (-C, looks fine.) testport: OK (poudriere: 9.3-R, 10.[123]-R, 11.0-RC3, amd64/i386, default options)
Created attachment 175701 [details] 0.1.8 New upstream release, bumping to that version.
Torsten: do I need to do anything to get this ready for commit? Everything should be in order, since it's a maintainer update, right?
Hello Bradley, yes everything is in order and correct. Thanks for your fine work! But since i'm new to the committer-team i need approval of my mentors for every commit. I already requested the approval and now i'm waiting for the "go" :)
Sounds good! :)
Created attachment 176114 [details] 0.1.9 Upstream has released 0.1.9, updated patch accordingly.
A commit references this bug: Author: tz Date: Tue Oct 25 08:52:46 UTC 2016 New revision: 424607 URL: https://svnweb.freebsd.org/changeset/ports/424607 Log: net/py-s3transfer: upgrade 0.1.5 to 0.1.8 Changelog: 0.1.8 - feature:download: Support downloading to FIFOs. 0.1.7 - bugfix:TransferManager: Fix memory leak when using same client to create multiple TransferManagers 0.1.6 - bugfix:download: Fix issue where S3 Object was not downloaded to disk when empty PR: 213353 Submitted by: Bradley T. Hughes (maintainer) Approved by: swills (mentor) Changes: head/net/py-s3transfer/Makefile head/net/py-s3transfer/distinfo
(In reply to Bradley T. Hughes from comment #6) > Upstream has released 0.1.9, updated patch accordingly. Thank you for your fast and good work! I'm sorry it took so long - i have 3 mentors but all of them were busy until today. Since they reviewed the patch for 0.1.8 and the new patch would need a new review by them, i just committed the version 0.1.8. Hopefully this will help. I would suggest to create a new PR for the new update. But if you want i can have a look at the new patch too ;) Greetings, Torsten
Can't we just leave this open with the updated patch? :)
(In reply to Bradley T. Hughes from comment #9) > Can't we just leave this open with the updated patch? :) We can. :)
Any chance we can get the 0.1.9 patch committed? It blocks updating devel/awscli to the latest upstream version. Thanks :)
I'm sorry. I was delayed because my wife got ill. I'm back today and starting to take care of all my PRs. This one shouldn't take long :) Tests are running :)
Hi Torsten! Sorry to hear about your wife, now I feel bad for nagging. Thanks for the update. :) Let me know if you need me to test anything more than what I've already done (all supported FreeBSD RELEASEs on amd64 and i386). Thanks again!
A commit references this bug: Author: tz Date: Fri Nov 4 11:33:27 UTC 2016 New revision: 425314 URL: https://svnweb.freebsd.org/changeset/ports/425314 Log: net/py-s3transfer: Update from 0.1.8 to 0.1.9 Changelog: - Add override flag to transfer coordinator - Don't override exceptions and only set them after done - Set exception on future PR: 213353 Submitted by: Bradley T. Hughes (maintainer) Approved by: pi (mentor) Changes: head/net/py-s3transfer/Makefile head/net/py-s3transfer/distinfo
> Sorry to hear about your wife, now I feel bad for nagging. No need for feeling sorry. You couldn't have know it - and this is how live is going. AND finally: committed! Thanks for your patch and patience! :)
Thanks to you as well, Torsten. Have a nice day! :)