Bug 213359 - graphics/poppler: Update to 0.48.0
Summary: graphics/poppler: Update to 0.48.0
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2016-10-10 15:22 UTC by Olivier Duchateau
Modified: 2016-12-17 20:17 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gnome)

Attachments
Patch to update graphics/poppler (2.10 KB, patch)
2016-10-10 15:22 UTC, Olivier Duchateau 		no flags Details | Diff
Patch to update graphics/poppler (3.16 KB, patch)
2016-10-10 18:21 UTC, Olivier Duchateau 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau freebsd_committer freebsd_triage 2016-10-10 15:22:47 UTC 
Created attachment 175602 [details]
Patch to update graphics/poppler

- Update to 0.48.0
- enable nss

No changes for slaves ports.

Tested with poudriere:

- i386 9.3: OK
- amd64 10.3, 11.0-RC3 : OK
Comment 1 John Hein 2016-10-10 16:37:18 UTC 
=> Patch patch-poppler_PDFDoc.cc failed to apply cleanly.

Original file has isDict, not isNull
Comment 2 John Hein 2016-10-10 16:59:22 UTC 
TLDR; USES=localbase is unnecessary, so it can be removed.

If devel/libc++ is installed (tested on 10.3-stable where c++ is clang and there is a libc++ in base /usr/lib):

====> Running Q/A tests (stage-qa)
Error: /usr/local/lib/libpoppler-cpp.so.0.3.0 is linked to /usr/local/lib/libc++.so.1 from devel/libc++ but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libc++.so:devel/libc++


This is because of -L/usr/local/lib appears before -L/usr/lib in the linker flags (and -rpath is specified as /usr/local/lib by default - unless you define PREFIX otherwise - see cpp/Makefile.in & poppler/Makefile.in).

Removing 'localbase' is not necessary as far as I can see, so removing it from USES helps the situation with the unrecorded dependency on devel/libc++:

 - ldd libpoppler.so & ldd libpoppler-cpp.so will report /usr/lib/libc++.so.1

 - the QA test still fails with a false positive because proxydeps() bogusly hard-codes LD_LIBRARY_PATH=${LOCALBASE}/lib, but that can be addressed separately.
Comment 3 Olivier Duchateau freebsd_committer freebsd_triage 2016-10-10 18:21:07 UTC 
Created attachment 175608 [details]
Patch to update graphics/poppler

Submit wrong patch, new one is fine.
Comment 4 John Hein 2016-10-10 23:26:17 UTC 
(In reply to Olivier Duchateau from comment #3)
This patch works for me (light testing).

USES=localbase can also be removed.
Comment 5 Olivier Duchateau freebsd_committer freebsd_triage 2016-10-11 04:58:41 UTC 
(In reply to John Hein from comment #4)

USES= localbase is required for slaves packages (poppler-utils, poppler-qt*) otherwise build fails.
Comment 6 Olivier Duchateau freebsd_committer freebsd_triage 2016-12-17 20:17:05 UTC 
Superseded by bug #215358