Bug 213384 - [patch] www/zend-framework: Make memcache dependency optional
Summary: [patch] www/zend-framework: Make memcache dependency optional
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: William Grzybowski
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-10-11 16:39 UTC by Fredrik Eriksson
Modified: 2016-10-13 13:31 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (wg)


Attachments
Patch to make memcache dependency optional (1.10 KB, patch)
2016-10-11 16:39 UTC, Fredrik Eriksson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fredrik Eriksson 2016-10-11 16:39:27 UTC
Created attachment 175628 [details]
Patch to make memcache dependency optional

At the moment databases/pecl-memcache and databases/pecl-memcached are always pulled in as run dependencies for the zend-framework port. However, as far as I can tell it has never been a hard requirement to have the memcache extensions to use the non-memcache parts of zend-framework.

The attached patch adds an MEMCACHE option to the port and will only pull in the memcache-dependencies if this option is set.

The MEMCACHE option is off by default in my patch. I think that is a saner default, but it may (obviously) break stuff that rely on the current port behaviour, so I guess that's up for discussion.


The reason I stumbled on this is because the pecl-memcache ports are not compatible with PHP7 (#208049, #207295), while zend-framework should be. So right now this is mostly a workaround for me to build zend-framework with PHP7.
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-10-13 13:15:20 UTC
A commit references this bug:

Author: wg
Date: Thu Oct 13 13:15:07 UTC 2016
New revision: 423913
URL: https://svnweb.freebsd.org/changeset/ports/423913

Log:
  www/zend-framework: Make memcache dependency optional

  PR:		213384
  Submitted by:	Fredrik Eriksson

Changes:
  head/www/zend-framework/Makefile