Bug 213399 - editors/linux-sublime3: Update to Build 3126, while on it add 64 bit support
Summary: editors/linux-sublime3: Update to Build 3126, while on it add 64 bit support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tijl Coosemans
URL:
Keywords: patch
: 215082 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-10-12 01:13 UTC by miguelmclara
Modified: 2016-12-08 19:09 UTC (History)
1 user (show)

See Also:

Attachments
update to 3.1.26 - add linux64 support (2.62 KB, patch)
2016-10-12 01:13 UTC, miguelmclara 		no flags Details | Diff
update to 3.1.26 - add linux64 support (4.63 KB, patch)
2016-10-12 01:18 UTC, miguelmclara 		miguelmclara: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description miguelmclara 2016-10-12 01:13:17 UTC 
Created attachment 175643 [details]
update to 3.1.26 - add linux64 support

This should update the port, but also enable installation of 32 or 64 bit depending on what the user wants.

"LINUX_ARCH" will be use to decide which version to install



### Portlint:
portlint                                                                   ⏎
WARN: Makefile: Consider defining LICENSE.
0 fatal errors and 1 warning found.



### 
sudo make check-plist
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)

####
sudo make stage-qa
====> Running Q/A tests (stage-qa)
Comment 1 miguelmclara 2016-10-12 01:18:44 UTC 
Created attachment 175644 [details]
update to 3.1.26 - add linux64 support

Update to 3.1.26 make sure diff include distinfo changes
Comment 2 VK freebsd_triage 2016-10-15 08:48:01 UTC 
Thanks for your contribution. The maintainer-approval(+) flag that you've set on the attachment is sufficient. No need to use summary hacks like adding "[maintainer]" to it.
Comment 3 miguelmclara 2016-10-15 13:17:57 UTC 
(In reply to Vladimir Krstulja from comment #2)
Sorry about that.
Comment 4 miguelmclara 2016-10-31 18:12:39 UTC 
I wonder if there's something wrong with my patch since this wasn't pushed to the ports three yet?

I just asked because its usually faster, unless something is wrong with the submitted patches, please let me known if that's the case.
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-12-08 13:53:03 UTC 
A commit references this bug:

Author: tijl
Date: Thu Dec  8 13:52:39 UTC 2016
New revision: 428118
URL: https://svnweb.freebsd.org/changeset/ports/428118

Log:
  Update to 3.1.26 and add 64-bit support.

  PR:		213399
  Submitted by:	miguelmclara@gmail.com (maintainer)

Changes:
  head/editors/linux-sublime3/Makefile
  head/editors/linux-sublime3/distinfo
  head/editors/linux-sublime3/files/sublime.in
  head/editors/linux-sublime3/pkg-plist
Comment 6 Tijl Coosemans freebsd_committer freebsd_triage 2016-12-08 13:58:32 UTC 
I've added support for architecture dependent distfiles to USES=linux and changed the Makefile to make use that.  A consequence is that you can keep one distinfo file; make makesum will do the right thing.  I've also simplified the startup script as discussed in bug 215082.  Let me know if you'd like to make any additional changes.
Comment 7 Tijl Coosemans freebsd_committer freebsd_triage 2016-12-08 14:00:24 UTC 
*** Bug 215082 has been marked as a duplicate of this bug. ***
Comment 8 miguelmclara 2016-12-08 19:09:07 UTC 
Sounds great, thanks 

And a thanks to "ericturgeon" for spotting the issue with the start script.