Bug 213470 - security/heimdal: install libcom_err headers
Summary: security/heimdal: install libcom_err headers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Sato
URL:
Keywords: easy, needs-qa
Depends on:
Blocks:
 
Reported: 2016-10-14 04:48 UTC by Franco Fichtner
Modified: 2016-11-02 10:00 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback+
koobs: merge-quarterly-

Attachments
add libcom_err headers to package (1.10 KB, patch)
2016-10-14 04:48 UTC, Franco Fichtner 		koobs: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Franco Fichtner 2016-10-14 04:48:04 UTC 
Created attachment 175731 [details]
add libcom_err headers to package

Hi,

I built a 11.0-RELEASE using WITHOUT_KERBEROS and noticed that sysutils/msktutil doesn't have GSSAPI knobs yet, so building there naturally fails.  However, building against heimdal (gssapi:heimdal) fails as well, because it misses the headers for libcom_err. For krb5 port (gssapi:mit) it already works as the headers are included.

Tested with poudriere on 11.0-RELEASE.

At your discretion, PORTREVISION may or may not be bumped, so far this is a build fix only for upcoming changes in sysutils/msktutil.


Cheers,
Franco
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2016-10-31 13:08:45 UTC 
testbuilds on 12a, 11a, 10i, 93a all fine.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2016-11-02 08:53:06 UTC 
Comment on attachment 175731 [details]
add libcom_err headers to package

Maintainer timeout (2 weeks), implicit approval. Open to take
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-11-02 09:51:52 UTC 
A commit references this bug:

Author: hrs
Date: Wed Nov  2 09:51:17 UTC 2016
New revision: 425129
URL: https://svnweb.freebsd.org/changeset/ports/425129

Log:
  Add missing header files (com_err.h and com_right.h).

  Submitted by:	Franco Fichtner
  PR:		213470

Changes:
  head/security/heimdal/Makefile
  head/security/heimdal/files/patch-lib-com_err-Makefile.in
  head/security/heimdal/pkg-plist
Comment 4 Hiroki Sato freebsd_committer freebsd_triage 2016-11-02 09:52:55 UTC 
Sorry for the long delay.  Committed the patch.  Thank you for your report!
Comment 5 Franco Fichtner 2016-11-02 10:00:21 UTC 
No worries, thank you.