Bug 213988 - sysutils/brasero: fix for lang/gcc5
Summary: sysutils/brasero: fix for lang/gcc5
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-01 20:06 UTC by Kenneth Salerno
Modified: 2018-04-02 17:34 UTC (History)
3 users (show)

See Also:

Attachments
Fix for lang/gcc5 (621 bytes, patch)
2016-11-01 20:06 UTC, Kenneth Salerno 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Salerno 2016-11-01 20:06:28 UTC 
Created attachment 176387 [details]
Fix for lang/gcc5
Comment 1 Gerald Pfeifer freebsd_committer freebsd_triage 2016-11-01 20:28:11 UTC 
The patch makes sense to me, unless Brasero's source can be fixed
(or adjusted).  Let me forward this to gnome@FreeBSD.org which is
listed as maintainer of this port.
Comment 2 Kenneth Salerno 2016-11-02 09:27:50 UTC 
(In reply to Gerald Pfeifer from comment #1)
Here is the actual compiler warning:

scsi-cam.c:243:76: error: format '%i' expects argument of type 'int', but argument 4 has type 'lun_id_t {aka long long unsigned int}' [-Werror=format=]
Comment 3 Gerald Pfeifer freebsd_committer freebsd_triage 2016-11-02 22:16:57 UTC 
(In reply to Kenneth Salerno from comment #2)
> scsi-cam.c:243:76: error: format '%i' expects argument of type 'int', but
> argument 4 has type 'lun_id_t {aka long long unsigned int}' [-Werror=format=] 

Instead of silencing the warning, wouldn't it be more appropriate to
adjust the format to '%llu'?  If the fourth argument is then cast to
(long long unsigned) that should be an approach even suitable for
upstream submission.
Comment 4 Kenneth Salerno 2016-11-03 02:46:02 UTC 
(In reply to Gerald Pfeifer from comment #3)
Agreed.
Comment 5 Ting-Wei Lan 2016-11-03 15:45:49 UTC 
I opened an upstream bug to track format string issues in brasero 19 months ago:
https://bugzilla.gnome.org/show_bug.cgi?id=747226

If you have source code patches to fix the problem, please upload it to both FreeBSD and GNOME bugzilla, so more people are able to find and see your work. Unfortunately, brasero has no upstream maintainer since last year, so patches uploaded to GNOME bugzilla are unlikely to be reviewed.