Created attachment 176409 [details] svn diff patch Recently I had a similar issue like bug #213296, but with deskutils/py-khal. khal depends on py-requests whereas livestreamer depends on py-requests1 resulting in that I can only install one of them. I tried to compile livestreamer with run-dependency www/py-requests and it does not seem to have any regressions (as already reported in bug #213296). Apart: If you take a look at github[1] it seems as if developing of livestreamer has stopped. Seems as if streamlink[2] is an up-to-date successor. [1] https://github.com/chrippa/livestreamer/commits/develop [2] https://github.com/streamlink/streamlink
Created attachment 176411 [details] output of "poudriere testport" on 11.0-RELEASE amd64
Thank you for the patch. Could you please run livestreamers test suite (with `python-x.y setup.py test` in WKRSRC after extracting) to confirm that tests pass with requests 2.x. I also note in setup.py, the following, which is a good indication that requests 2.x support is OK: # requests 2.0 does not work correctly on Python <2.6.3 if (version_info[0] == 2 and version_info[1] == 6 and version_info[2] < 3): deps.append("requests>=1.0,<2.0") else: deps.append("requests>=1.0,<3.0") For reference, all ports depending on www/py-requests in the past were changed to requests1 [1][2] when py-requests was updated to 2.x, allowing individual port maintainers to make the change to the later version themselves. [1] https://svnweb.freebsd.org/ports?view=revision&revision=341384 [2] https://svnweb.freebsd.org/ports?view=revision&revision=341385
Created attachment 176413 [details] output of "python2.7 setup.py test" I don't know if this checks for run dependencies (like py-requests) or just for installing/compiling dependencies. Anyway here is the result ...
If the tests require/use requests, and www/py-requests is installed it will be found, if not, it will be installed by setuptools (if requests its listed as a tests_require in setup.py) What would invalidate the test is having the requests1 port installed, as setuptools would have found and used *it* (version 1.x) instead. If it was installed, deinstall it and re-run the test with either www/py-requests installed, or if its listed in setup.py:install_requires, just let setuptools install it.
OK, what I did was: I executed "make" in livestreamers portsdir in a clean environment resulting in the following packages being installed: ports-mgmt/dialog4ports devel/gettext-runtime devel/gettext-tools print/indexinfo devel/libffi multimedia/librtmp ports-mgmt/pkg devel/pkgconf devel/py-cffi devel/py-futures multimedia/py-librtmp devel/py-pycparser www/py-requests devel/py-setuptools27 devel/py-singledispatch devel/py-six lang/python27 devel/readline multimedia/rtmpdump Note that www/py-requests was installed. After that I did this "setup.py test" with the results already submitted.
In regards to the comment in the initial report about streamlink being the successor to livestream, I had submitted a bug report in #213489 to add streamlink to the ports tree.
A commit references this bug: Author: riggs Date: Thu Jan 5 17:30:55 UTC 2017 New revision: 430646 URL: https://svnweb.freebsd.org/changeset/ports/430646 Log: Resolve dependency conflicts with www/py-requests; bump PORTREVISION PR: 213999 Submitted by: kaltheat@gmail.com MFH: 2017Q1 Changes: head/multimedia/livestreamer/Makefile
A commit references this bug: Author: riggs Date: Fri Jan 6 10:15:50 UTC 2017 New revision: 430700 URL: https://svnweb.freebsd.org/changeset/ports/430700 Log: MFH: r430646 Resolve dependency conflicts with www/py-requests; bump PORTREVISION PR: 213999 Submitted by: kaltheat@gmail.com Approved by: ports-secteam (junovitch) Changes: _U branches/2017Q1/ branches/2017Q1/multimedia/livestreamer/Makefile