Bug 214199 - cad/netgen: fails to build with FFMPEG=on if multimedia/ffmpeg isn't installed
Summary: cad/netgen: fails to build with FFMPEG=on if multimedia/ffmpeg isn't installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Stephen Montgomery-Smith
URL:
Keywords: patch, patch-ready
Depends on:
Blocks: 214644
  Show dependency tree / graph
 
Reported: 2016-11-04 07:19 UTC by Jan Beich
Modified: 2016-11-20 16:11 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (stephen)

Attachments
respect PREFIX (4.34 KB, patch)
2016-11-05 04:50 UTC, Jan Beich 		no flags Details | Diff
link with libswscale0 (1.35 KB, patch)
2016-11-05 04:51 UTC, Jan Beich 		jbeich: maintainer-approval? (stephen)
 Details | Diff
respect PREFIX (4.27 KB, patch)
2016-11-05 04:55 UTC, Jan Beich 		jbeich: maintainer-approval? (stephen)
 Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2016-11-04 07:19:33 UTC 
/bin/sh ../libtool --tag=CXX   --mode=link c++  -O2 -pipe -fstack-protector -fno-strict-aliasing   -export-dynamic -L/usr/local/lib -fstack-protector -o netgen demoview.o ngappinit.o onetcl.o parallelfunc.o ngpkg.o ../libsrc/visualization/libvisual.la ../libsrc/csg/libcsgvis.la ../libsrc/csg/libcsg.la ../libsrc/interface/libinterface.la ../libsrc/meshing/libmesh.la -ltogl -lGLU -L/usr/local/lib -ltk86 -L/usr/local/lib -ltcl86  -L/usr/local/lib/ffmpeg0 -lavutil0 -lavformat0 -lavcodec0 -lavutil0 -lswscale -lz -lbz2 -ljpeg -lGL -lXmu -lX11   
/usr/bin/ld: cannot find -lswscale
c++: error: linker command failed with exit code 1 (use -v to see invocation)

http://package23.nyi.freebsd.org/data/103i386-default-PR207547/2016-10-04_18h24m30s/logs/errors/netgen-5.3.1.log
Comment 1 Jan Beich freebsd_committer freebsd_triage 2016-11-05 04:49:50 UTC 
There're 2 issues: netgen may link against
- libswscale from multimedia/ffmpeg
- multimedia/ffmpeg0 installed under different PREFIX
Comment 2 Jan Beich freebsd_committer freebsd_triage 2016-11-05 04:50:48 UTC 
Created attachment 176647 [details]
respect PREFIX
Comment 3 Jan Beich freebsd_committer freebsd_triage 2016-11-05 04:51:54 UTC 
Created attachment 176648 [details]
link with libswscale0
Comment 4 Jan Beich freebsd_committer freebsd_triage 2016-11-05 04:55:49 UTC 
Created attachment 176649 [details]
respect PREFIX

Sort *FLAGS and slightly reword commit message.
Comment 5 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2016-11-13 16:44:22 UTC 
Excuse my delay in getting this done.  I will get to it, but life is very busy for me right now.

Thank you for doing this.
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-11-20 16:10:20 UTC 
A commit references this bug:

Author: stephen
Date: Sun Nov 20 16:09:52 UTC 2016
New revision: 426602
URL: https://svnweb.freebsd.org/changeset/ports/426602

Log:
  - When FFMPEG=on, link to multimedia/ffmpeg.
  - Respect PREFIX.
  - Conversion for avcodec_encode_video().

  PR:		ports/214199
  PR:		ports/214644

Changes:
  head/cad/netgen/Makefile
  head/cad/netgen/files/patch-configure
  head/cad/netgen/files/patch-ng_ng.tcl
  head/cad/netgen/files/patch-ng_ngappinit.cpp
  head/cad/netgen/files/patch-ng_ngpkg.cpp
Comment 7 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2016-11-20 16:11:22 UTC 
Committed, thank you.