Bug 214267 - audio/logitechmediaserver does not build with perl 5.24
Summary: audio/logitechmediaserver does not build with perl 5.24
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ben Woods
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-11-06 14:28 UTC by Mark Dixon
Modified: 2016-11-13 17:21 UTC (History)
2 users (show)

See Also:
mark: maintainer-feedback+


Attachments
Proposed fix for perl 524 (6.01 KB, patch)
2016-11-06 15:17 UTC, Mark Dixon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Dixon 2016-11-06 14:28:34 UTC
audio/logitechmediaserver does not build with perl 5.24 due to it's horrible custom build shell script.

I'm working on a fix.
Comment 1 Mark Dixon 2016-11-06 15:17:19 UTC
Created attachment 176687 [details]
Proposed fix for perl 524

This is a patch to build on 5.24. Poudriere tested on 9.3 and 10.3, builds on 11R
Comment 2 Ben Woods freebsd_committer 2016-11-13 05:30:56 UTC
Hi Mark,

Thanks for submitting this - about to commit it now. Just thoughts I'd let you know a couple of minor changes I made to the your patch.

1. Use ${CP} -R instead of ${CP} -r, as this is the correct syntax on BSD:
https://man.freebsd.org/cp

2. In vendorpatch-CPAN_buildme.sh, you had these lines twice (I removed one):
+    "5.24")
+     PERL_524=$PERL_BIN
+        ;;

Like I said - minor things :)
Comment 3 Ben Woods freebsd_committer 2016-11-13 05:34:04 UTC
Also, would you mind creating two pull requests on the upstream GitHub repos?
- One for GH/Logitech/slimserver to add the CPAN/arch/5.24 directory
- One for GH/Logitech/slimserver-vendor with your 5.24 additions?

Thanks - this will help keep our local changes to a minimum.
Comment 4 Ben Woods freebsd_committer 2016-11-13 05:35:38 UTC
Note: to keep the GH/Logitech/slimserver-vendor pull request specific to adding perl 5.24 support, I wouldn't submit all of our changes in vendorpatch-CPAN_buildme.sh... just those changes you have submitted in this bug report.
Comment 5 Ben Woods freebsd_committer 2016-11-13 05:56:04 UTC
Committed, thanks!
Comment 6 commit-hook freebsd_committer 2016-11-13 05:56:42 UTC
A commit references this bug:

Author: woodsb02
Date: Sun Nov 13 05:55:50 UTC 2016
New revision: 426008
URL: https://svnweb.freebsd.org/changeset/ports/426008

Log:
  audio/logitechmediaserver: Fix build with perl 5.24

  PR:		214267
  Submitted by:	Mark Dixon (maintainer)
  Reported by:	Alan Braslau <alan.braslau@comcast.net>
  Approved by:	adamw (mentor, implicit)

Changes:
  head/audio/logitechmediaserver/Makefile
  head/audio/logitechmediaserver/files/vendorpatch-CPAN_buildme.sh
Comment 7 Mark Dixon 2016-11-13 17:21:04 UTC
Thanks Ben, yes getting 5.24 support upstream is on my todo list.