Bug 214409 - Compile failure in libexec/ftpd/ftpd.c due to undefined macros when blacklist support is disabled
Summary: Compile failure in libexec/ftpd/ftpd.c due to undefined macros when blacklist...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 11.0-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Lidl
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-11-10 21:09 UTC by Matthew Rezny
Modified: 2016-11-15 23:05 UTC (History)
1 user (show)

See Also:

Attachments
unconditionally include header to prevent compile failure caused by undefined macros (344 bytes, patch)
2016-11-10 21:09 UTC, Matthew Rezny 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Rezny freebsd_committer freebsd_triage 2016-11-10 21:09:08 UTC 
Created attachment 176872 [details]
unconditionally include header to prevent compile failure caused by undefined macros

The recent blacklist change to ftpd in r308175/r308446 consolidated most occurrences of #ifdef USE_BLACKLIST by replacing the blacklist function calls with macros. However, those macros are defined in a header whose inclusion is still wrapped in a #ifdef USE_BLACKLIST. Thus, when blacklist support is disabled the macros are undefined and compilation of ftpd.c fails. The blacklist_client.h header should be included unconditionally.
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-11-12 03:08:15 UTC 
A commit references this bug:

Author: lidl
Date: Sat Nov 12 03:07:41 UTC 2016
New revision: 308567
URL: https://svnweb.freebsd.org/changeset/base/308567

Log:
  Fix build when WITHOUT_BLACKLIST=yes is specified

  PR:		214409
  Submitted by:	matthew
  Reported by:	matteo
  MFC after:		3 days
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/libexec/ftpd/ftpd.c
Comment 2 Kurt Lidl freebsd_committer freebsd_triage 2016-11-15 23:05:30 UTC 
Patch has been merged into stable/11 with commit r308703.