Bug 214437 - editors/libreoffice and editors/libreoffice4: fail to build with ICU 58.1
Summary: editors/libreoffice and editors/libreoffice4: fail to build with ICU 58.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: FreeBSD Office Team
URL:
Keywords: patch, patch-ready
Depends on:
Blocks: 214384
  Show dependency tree / graph
 
Reported: 2016-11-12 11:02 UTC by Jan Beich
Modified: 2016-11-15 15:31 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (office)

Attachments
v1 (5.60 KB, patch)
2016-11-12 16:57 UTC, Jan Beich 		koobs: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2016-11-12 11:02:23 UTC 
i18npool/source/breakiterator/breakiterator_unicode.cxx:69:13: error: 'setBreakType' is a private member of 'icu::RuleBasedBreakIterator'
            setBreakType(type);
            ^
/usr/local/include/unicode/rbbi.h:657:10: note: declared private here
    void setBreakType(int32_t type);
         ^
1 error generated.

https://ssl.icu-project.org/trac/changeset/38666
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3e42714c76b1347babfdea0564009d8d82a83af4
Comment 1 Jan Beich freebsd_committer freebsd_triage 2016-11-12 11:04:17 UTC 
Hmm, it appears editors/libreoffice* miss intermediate ICU patches e.g., for ICU 57.1.
Comment 2 Baptiste Daroussin freebsd_committer freebsd_triage 2016-11-12 11:37:02 UTC 
is libreoffice 5.2.3 still inpacted (I would say yes according to your patch)?
Comment 3 Jan Beich freebsd_committer freebsd_triage 2016-11-12 16:57:15 UTC 
Created attachment 176928 [details]
v1

This should be safe to land before bug 214384. It doesn't try to handle additional scripts from Unicode 9.0 unlike upstream commit.
Comment 4 Jan Beich freebsd_committer freebsd_triage 2016-11-12 19:44:26 UTC 
Comment on attachment 176928 [details]
v1

poudriere bulk -t is green with both ICU 57.1 (on 10.3 amd64) and 58.1 (on 11.0 i386).
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2016-11-15 14:14:27 UTC 
Comment on attachment 176928 [details]
v1

Change is Approved by: portmgr (blanket)
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-11-15 15:30:00 UTC 
A commit references this bug:

Author: jbeich
Date: Tue Nov 15 15:29:16 UTC 2016
New revision: 426173
URL: https://svnweb.freebsd.org/changeset/ports/426173

Log:
  editors/libreoffice: unbreak against ICU 58.1

  i18npool/source/breakiterator/breakiterator_unicode.cxx:69:13: error: 'setBreakType' is a private member of 'icu::RuleBasedBreakIterator'
              setBreakType(type);
              ^
  /usr/local/include/unicode/rbbi.h:657:10: note: declared private here
      void setBreakType(int32_t type);
           ^
  1 error generated.

  PR:		214437
  Obtained from:	upstream
  Approved by:	portmgr blanket

Changes:
  head/editors/libreoffice/files/patch-i18npool_source_breakiterator_breakiterator__unicode.cxx
  head/editors/libreoffice4/files/patch-i18npool_source_breakiterator_breakiterator__unicode.cxx