Created attachment 177084 [details]
ISPC should be supported by default.
Please also note that other USES are also missing when all options are chosen. (see stage-qa warnings)
Can you elaborate why do you think that ISPC should be supported by default? Admittedly, I was thinking about introducing it as an optional feature.
ISPC pulls in quite heavy (and non-standard) clang/llvm38 ports as a dependencies which some users might not appreciate in order to build Embree and its consuming ports.
I think science/ospray requires ISPC support in embree. It was a while ago, I don't remember if this was the case or something else.
Now I remember: ospree has a cmake variable for 'embree has ispc support'. Ospree also required ispc nonoptionally. I decided to add both ispc and its support in embree, since it was missing.
A commit references this bug:
Date: Fri Dec 29 16:46:46 UTC 2017
New revision: 457515
- Belatedly update `graphics/embree' to the latest version, 2.17.1
- Add ISPC option and enable it by default (this pulls rather heavy
`devel/llvm50' via BUILD_DEPENDS and normally would not be enabled
by default, but since Embree is most likely to be used in graphics
applications, it is safe to assume that users already have LLVM 5
installed because X.org/Mesa stack unconditionally requires it)
- OpenEXR support was removed upstream since version 2.13.0 back in
November 11, 2016: https://github.com/embree/embree/commit/483491e
(as usual, unfortunately, no explanation was provided in the log)
- Remove CXXFLAGS+=-msse2 required for i386 earlier, not needed now
- Add missing USE_GL, USE_XORG components as prompted by `stage-qa'
PR: 214577, 224066
Because GitHub releases (tarballs) are not fetched with correct modification
time, set TIMESTAMP to 1510648523 which corresponds to commit 90e49f2 tagged
as this release.
Committed as of ports r457515, thank you.