Bug 214584 - graphics/rawtherapee posts warnings if x11-themes/gtk-engines2 is not installed
Summary: graphics/rawtherapee posts warnings if x11-themes/gtk-engines2 is not installed
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-16 20:36 UTC by freebsd
Modified: 2017-01-29 18:38 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description freebsd 2016-11-16 20:36:26 UTC
When running rawtherapee under xfce4 in a minimal configuration,
the x11-themes/gtk-engines2 port is not installed.
However, rawtherapee installs a default .config/Rawtherapee4.1/options
file which sets a theme of "25-Gray-Gray.gtkrc"
  "/usr/local/share/rawtherapee/themes/25-Gray-Gray.gtkrc"
This causes numerous warnings on startup and at other points about the missing theme "clearlooks"

The rawtherapee port should either have x11-themes/gtk-engines2 as a dependency,
or better, suppress the warnings if no theme is explicitly expressed by the user
or the installation; it seems to run just fine without gtk-engines2 installed.
This may be a situation which exists with other gtk based apps.

All of this happens fairly early on in rawtherapee's main() method,
line 143.

I am extracting this as a separate piece of bug 214509, as it is mainly cosmetic and it is unrelated to the core dump which is the main focus of 214509.
Comment 1 freebsd 2016-11-16 20:37:13 UTC
add cross reference to 214509
Comment 2 freebsd 2016-11-17 00:10:30 UTC
Getting rid of the warnings without gtk-engines2 installed is fairly simple -- set the option "UseSystemTheme" to true.  That seems to override the specific theme set in the "Theme" option.

This may or may not be a desirable default behaviour, depending on your perspective.  When no system theme is installed, you get "normal" backgrounds, generally white with grey headers.  While fine for many applications, it is not generally desirable for photo-editing apps.  What I don't understand is why I see the 25-Gray-Gray theme when I don't have gtk-engines2 installed.  If that happens because the total absense of a theme (no user specific, system use set to false) results in hard-coded values corresponding to 25-Gray-Gray, then having the default for the "Theme" option set to something like "none", leaving the use system theme set to false, and setting an error handler to trap and discard the warning messages might be appropriate.

I suspect that's not a high priority ;-), so forcing a dependency is probably the prudent path to take.
Comment 3 Matthias Andree freebsd_committer 2016-11-17 00:54:58 UTC
Do you have a desktop environment installed via one of the master/meta ports? 
If yes, which one? gnome and -lite and mate already list gtk-engines2 as requisite.
Comment 4 Matthias Andree freebsd_committer 2016-11-17 00:55:30 UTC
(my question meaning: which is the all-encompassing xfce* port that you install)
Comment 5 freebsd 2016-11-17 01:36:11 UTC
I have no all-encompassing desktop port installed.  Essentially, all I have installed is a window manager, xfce4.  Something not uncommon among hardened criminals ;-) but in any case a reasonable choice.  For example, consider the X minimalist who installs twm and nothing.
Comment 6 Matthias Andree freebsd_committer 2017-01-29 18:38:48 UTC
rawtherapee-5.0-gtk3 now uses Gtk+3 and should not require the gtk-engines2 port any more. Please reopen this bug if it does counter to what I'm writing.