Bug 214642 - comms/jsdr : switch to using qmake
Summary: comms/jsdr : switch to using qmake
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-18 22:47 UTC by Tobias C. Berner
Modified: 2016-11-19 11:54 UTC (History)
1 user (show)

See Also:


Attachments
Simplify Makefile (6.09 KB, patch)
2016-11-18 22:47 UTC, Tobias C. Berner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias C. Berner freebsd_committer 2016-11-18 22:47:10 UTC
Created attachment 177160 [details]
Simplify Makefile

Hi

Instead of doing a manual do-configure / do-build / do-install targets, the attached patch copies a small 'jsdr.pro' file to WRKSRC and then relies on USES=qmake to do the rest:

+--------------------------------------+
| TEMPLATE = subdirs                   |
|                                      |
| SUBDIRS = make-x64/swreceiver \      |
|           make-x64/fmreceiver \      |         
|           make-x64/spectrum-viewer \ |
|           make-x64/mini-receiver     |
|                                      |
| CONFIG += ordered                    |
+--------------------------------------+

And modifies the patches to the four .pro files in the subdirs to create an install target.


The version-suffix of the two binaries spectrum-viewer and fmreceiver was dropped in the process (why was it there?).


mfg Tobias
Comment 1 Diane Bruce freebsd_committer 2016-11-19 00:09:41 UTC
Any reason you didn't take the port yourself? ;)
Comment 2 Tobias C. Berner freebsd_committer 2016-11-19 00:19:57 UTC
Hi Diane 

Because this is only a drive by shooting of some qt/qmake related changes =). 



mfg Tobias
Comment 3 commit-hook freebsd_committer 2016-11-19 11:53:47 UTC
A commit references this bug:

Author: tcberner
Date: Sat Nov 19 11:53:24 UTC 2016
New revision: 426360
URL: https://svnweb.freebsd.org/changeset/ports/426360

Log:
  Simplify Makefile of comms/jsdr

  Instead of doing a manual do-configure / do-build / do-install targets, copy
  a small 'jsdr.pro' file to WRKSRC and then rely on USES=qmake to do the rest.

  The version-suffix of the two binaries spectrum-viewer and fmreceiver was
  dropped in the process (why was it there?) -- and therefore the PORTREVISION
  is bumped.

  PR:		214642
  Approved by:	rakuco (mentor)

Changes:
  head/comms/jsdr/Makefile
  head/comms/jsdr/files/patch-jsdr.pro
  head/comms/jsdr/files/patch-make-x64_fmreceiver_fmreceiver.pro
  head/comms/jsdr/files/patch-make-x64_mini-receiver_mini-receiver.pro
  head/comms/jsdr/files/patch-make-x64_spectrum-viewer_spectrum-viewer.pro
  head/comms/jsdr/files/patch-make-x64_swreceiver_swreceiver.pro