Created attachment 177197 [details] full diff i) 2012.09.13r1 -> 2012.09.13 ii) s|/usr/share|${LOCALBASE}/share in config/window.lua iii) git mason-larobina -> luakit
Thanks for the patch. Can you please confirm the changes pass QA (portlint, poudriere)?
Comment on attachment 177197 [details] full diff The port has no maintainer, implicit approval.
This would be rolling the version backwards. The 2012.09.13-r1 tag is after the 2012.09.13 tag: https://github.com/luakit/luakit/tags
(In reply to Jason E. Hale from comment #3) Ouch, indeed. I'll just fix some issues in that release then. Will update the patch soon.
Jason, I'll take care :)
Created attachment 178027 [details] minor fixes
clutton, cc -c common/luaclass.c -o common/luaclass.o luakit.c:174:9: warning: 'g_thread_init' is deprecated [-Wdeprecated-declarations] g_thread_init(NULL); ^ /usr/local/include/glib-2.0/glib/deprecated/gthread.h:265:10: note: 'g_thread_init' has been explicitly marked deprecated here void g_thread_init (gpointer vtable); ^ 1 warningcc -c clib/timer.c -o clib/timer.o generated. Please, remove deprecated `g_thread_init` which is not longer necessary since version 2.32. https://github.com/luakit/luakit/commit/0ab977bfd3bf0912c95d3e8991238b9d88639a79
All build logs are fine on 10.3/i386, 10.3/amd64, 11.0/i386 and 11.0/amd64.
(In reply to Carlos J. Puga Medina from comment #8) It's not necessary. Just deprecation warning during building, fixing it would change nothing, it's better to stick with mainstream here, they'll remove this call eventually.
(In reply to clutton from comment #9) Waiting for mentor approval to commit the update.
Approved. You may just drop GH_ACCOUNT, it defaults to PORTNAME.
Created attachment 178217 [details] latest
Done, didn't know about that default.
A commit references this bug: Author: cpm Date: Fri Dec 23 16:04:44 UTC 2016 New revision: 429274 URL: https://svnweb.freebsd.org/changeset/ports/429274 Log: www/luakit: minor fixes - Drop GH_ACCOUNT - Use REINPLACE_CMD in config/window.lua - Bump PORTREVISION PR: 214682 Submitted by: clutton@zoho.com Reviewed by: Vladimir Krstulja, jhale, amdmi3 Approved by: amdmi3 (mentor) Changes: head/www/luakit/Makefile head/www/luakit/distinfo
Committed, thanks!