Bug 214729 - [NEW PORT] sysutils/u-boot-orangepi-plus-2e: slave port for u-bootorangepi-plus-2e ARM SoC board u-boot support
Summary: [NEW PORT] sysutils/u-boot-orangepi-plus-2e: slave port for u-bootorangepi-pl...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Some People
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-22 10:23 UTC by vova
Modified: 2017-06-25 23:48 UTC (History)
3 users (show)

See Also:

Attachments
Makefile and pkg-descr (2.04 KB, application/x-shar)
2016-11-22 10:23 UTC, vova 		no flags Details
port files (updated) (2.05 KB, application/x-shar)
2016-11-23 01:17 UTC, vova 		no flags Details
port in shell archive, v2 (1.98 KB, application/x-shar)
2017-04-11 10:16 UTC, vova 		no flags Details
shar file (2.03 KB, text/plain)
2017-05-17 08:06 UTC, Jov 		no flags Details
shar file (2.02 KB, text/plain)
2017-05-17 11:36 UTC, Jov 		no flags Details
port in shell archive, v4 (2.01 KB, application/x-shar)
2017-05-23 18:41 UTC, vova 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description vova 2016-11-22 10:23:11 UTC 
Created attachment 177265 [details]
Makefile and pkg-descr

Add a slave port for u-bootorangepi-plus2e ARM SoC board u-boot support.
This board is supported by FreeBSD for some times now but official u-boot release was lacking of support until now.

very similar to #211043, but for other OrangePi board
Comment 1 vova 2016-11-22 10:51:31 UTC 
Required for crochet tool pull-request:
https://github.com/freebsd/crochet/pull/168
Comment 2 vova 2016-11-23 01:17:57 UTC 
Created attachment 177307 [details]
port files (updated)
Comment 3 Gleb Popov freebsd_committer freebsd_triage 2017-04-10 06:09:25 UTC 
Any progress on this?
Comment 4 vova 2017-04-11 09:38:36 UTC 
> Any progress on this?

1. Crochet part committed long ago.
2. Waiting for somebody who will commit port (Mark?)
Comment 5 vova 2017-04-11 10:16:58 UTC 
Created attachment 181683 [details]
port in shell archive, v2

- fresh version
- silent warnings in portlint -AC
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2017-04-11 20:52:06 UTC 
I won't be able to get to this until the week after next at the earliest.  Someone else should take it.
Comment 7 James Elstone 2017-05-07 12:36:49 UTC 
From an outsider point of view:

This PR (u-boot-orangepi-plus-2e) sets
   'MASTERDIR= ${.CURDIR}/../u-boot-olimex-a20-som-evb'

The Olimex A20 port sets
  'MASTERDIR= ${.CURDIR}/../u-boot-master'

Thus this current PR (attachment 181683 [details]) is dependent on the 'Olimex A20' meta port which links to 'u-boot-master'.

This PR (u-boot-orangepi-plus-2e) could have set 
  'FAMILY= allwinner'
  'MASTERDIR= ${.CURDIR}/../u-boot-master' 

Why not link to the u-boot-master directly and specify the FAMILY; just wanted to understand the logic rather than challenge it?

James
Comment 8 Jov 2017-05-17 08:06:41 UTC 
Created attachment 182655 [details]
shar file

the Origin port have some problems:
1.MASTERDIR should be u-boot-master,or the name of the package it build will be wrong.
2.lack MAINTAINER.
3.COMMENT mention orange pi one,should be orange pi plus 2e.

fix by the new har file.
Comment 9 Jov 2017-05-17 11:36:28 UTC 
Created attachment 182660 [details]
shar file

the maintainer should be the origin submiter
Comment 10 vova 2017-05-23 18:41:17 UTC 
Created attachment 182835 [details]
port in shell archive, v4

Fix MAINTAINER, refer ../u-boot-master as masterdir
Comment 11 Mark Linimon freebsd_committer freebsd_triage 2017-06-25 23:47:42 UTC 
Committed, thanks.
Comment 12 commit-hook freebsd_committer freebsd_triage 2017-06-25 23:47:48 UTC 
A commit references this bug:

Author: linimon
Date: Sun Jun 25 23:47:24 UTC 2017
New revision: 444329
URL: https://svnweb.freebsd.org/changeset/ports/444329

Log:
  Add slave port for u-bootorangepi-plus2e ARM SoC board u-boot support.

  PR:		214729
  Submitted by:	vova@fbsd.ru

Changes:
  head/sysutils/Makefile
  head/sysutils/u-boot-orangepi-plus-2e/
  head/sysutils/u-boot-orangepi-plus-2e/Makefile
  head/sysutils/u-boot-orangepi-plus-2e/pkg-descr