Created attachment 177323 [details] full patch Hi, Attached patch updates pecl-radius to 1.4.0b1, which simply added PHP 7 support on top of the current 1.3.0 code. https://pecl.php.net/package/radius Builds fine on 10.3 amd64+i386, 11.0 amd64+i386, PHP 5.6 and PHP 7.0 Works fine on 10.3 amd64+i386. Sponsored by: OPNsense Cheers, Franco
Note: requesting MAINTAINER status
Jochen, please review Franco's patch and let us know if you approve of the proposed update. Thank you. Cheers, Matthias
Jochen was assigned maintainer after this bug went in, so I guess he simply missed it. Still offering maintainer status for this. This version runs successfully in production environments around the world. :)
Approved Poudriere build fine for: 9.3 amd + i386 10.3 amd + i386 11.0 amd + i386 12-current amd + i386 (r307551) portlint is also fine. Make test is fine, too. Cheers jochen
Comment on attachment 177323 [details] full patch >From 8786340e83e0ca0684df4d4ec5242a56b5e78165 Mon Sep 17 00:00:00 2001 >From: Franco Fichtner <franco@opnsense.org> >Date: Sun, 9 Oct 2016 19:19:36 +0200 >Subject: [PATCH] net/pecl-radius: 1.4.0b1 with PHP 7.0 support > >--- > net/pecl-radius/Makefile | 4 +--- > net/pecl-radius/distinfo | 5 +++-- > 2 files changed, 4 insertions(+), 5 deletions(-) > >diff --git a/net/pecl-radius/Makefile b/net/pecl-radius/Makefile >index 6694285..10cf6d4 100644 >--- a/net/pecl-radius/Makefile >+++ b/net/pecl-radius/Makefile >@@ -2,8 +2,7 @@ > # $FreeBSD$ > > PORTNAME= radius >-DISTVERSION= 1.3.0 >-PORTREVISION= 1 >+DISTVERSION= 1.4.0b1 > CATEGORIES= net security pear > MASTER_SITES= http://pecl.php.net/get/ > PKGNAMEPREFIX= pecl- >@@ -15,7 +14,6 @@ COMMENT= Radius client library for PHP > LICENSE= BSD3CLAUSE > > USES= php:ext tar:tgz >-IGNORE_WITH_PHP= 70 > > CONFIGURE_ARGS= --enable-radius > >diff --git a/net/pecl-radius/distinfo b/net/pecl-radius/distinfo >index d731f38..f30cc07 100644 >--- a/net/pecl-radius/distinfo >+++ b/net/pecl-radius/distinfo >@@ -1,2 +1,3 @@ >-SHA256 (PECL/radius-1.3.0.tgz) = b0431ec6769ff1ec564d95782f7b91de06a7ac3297745bbbc9d1c274bfc4de15 >-SIZE (PECL/radius-1.3.0.tgz) = 43060 >+TIMESTAMP = 1476033543 >+SHA256 (PECL/radius-1.4.0b1.tgz) = 97dcf2e497131a20804cc508873a123012b773f42d077af398334f3caf86ee54 >+SIZE (PECL/radius-1.4.0b1.tgz) = 50953
Thanks! Please note: Jochen keeps MAINTAINER status
hm, "Flags:Requestee:maintainer-approval +" doesn't work ... but, patch is okay, and ready for commit
There are some format string bugs in the code (emitted as compiler warnings), just one example: /wrkdirs/usr/ports/net/pecl-radius/work/radius-1.4.0b1/radlib.c:1226:48: warning: format specifies type 'int' but the argument has type 'size_t' (aka 'unsigned long') [-Wformat] generr(h, "Key to long (%d) for me max. %d", *len, MPPE_KEY_LEN); ~~ ^~~~ %zu Please take this up to the upstream maintainer.
A commit references this bug: Author: mandree Date: Fri Dec 23 22:08:16 UTC 2016 New revision: 429288 URL: https://svnweb.freebsd.org/changeset/ports/429288 Log: NMU to version 1.4.0b1, adding PHP 7 support. PR: 214774 Submitted by: Franco Fichtner <franco@opnsense.org> Approved by: Jochen Neumeister (maintainer) Sponsored by: OPNsense Changes: head/net/pecl-radius/Makefile head/net/pecl-radius/distinfo
It doesn't build for me in Poudriere with a 9.3 amd64 jail, but given that 9.3 is going out of support in 8 days I'll take your word that it works, it might be a local issue with my 9.3 jail.