Bug 215442 - www/grafana3: directory /var/run/grafana3 not created at service start time (only at installation time)
Summary: www/grafana3: directory /var/run/grafana3 not created at service start time (...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-20 14:55 UTC by Mark.Martinec
Modified: 2017-01-20 00:09 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (jhixson)


Attachments
Create /var/run/grafana3/ for the PID file on startup (873 bytes, patch)
2017-01-05 21:11 UTC, Brad Davis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark.Martinec 2016-12-20 14:55:23 UTC
Please see Bug 213857 for details, discussion and a fix, the issue is
the same as it was for the databases/influxdb port, which is now fixed.

This same problem report also applies to www/grafana2 (do I need
to open a separate PR for that port?)


Using grafana3-3.1.1_1 on 11.0-RELEASE

A directory /var/run/grafana3 is assumed to exist at the grafana3 service
start time (to receive its pid file), yet the /usr/local/etc/rc.d/grafana3
startup script does not insure existence of this directory.
Instead, it relies on the package installation to create it.

This results in an grafana3 service failing to start if /var/run
is cleaned at machine boot time, or if it resides on an ephemeral
file system (like tmpfs), which is re-created at boot time.

Reliance on the installation script to create a directory on /var/run
is unlike most other ports, which populate the /var/run with whatever
they need during service startup time.

Please update the 'www/grafana3' port so that its
/usr/local/etc/rc.d/grafana3 script will create /var/run/grafana3
directory (if missing) at service startup time.
Comment 1 Brad Davis freebsd_committer freebsd_triage 2017-01-05 21:11:18 UTC
Created attachment 178560 [details]
Create /var/run/grafana3/ for the PID file on startup

Here is a patch to add this functionality to www/grafana3.
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-01-20 00:05:35 UTC
A commit references this bug:

Author: brd
Date: Fri Jan 20 00:04:37 UTC 2017
New revision: 431922
URL: https://svnweb.freebsd.org/changeset/ports/431922

Log:
  For www/grafana3 create the run directory on startup for systems where
  /var/run is on a ramdisk.

  PR:		215442
  Reported by:	Mark.Martinec@ijs.si
  Approved by:	bdrewery (implicit)

Changes:
  head/www/grafana3/Makefile
  head/www/grafana3/files/grafana3.in
Comment 3 Brad Davis freebsd_committer freebsd_triage 2017-01-20 00:09:21 UTC
Please reopen if this commit doesn't fix the issue.  Thanks for reporting!