Bug 215490 - devel/bazel updated to 0.4.4
Summary: devel/bazel updated to 0.4.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-22 12:43 UTC by Klaus Aehlig
Modified: 2017-02-02 06:36 UTC (History)
1 user (show)

See Also:

Attachments
Patch to update bazel to 0.4.3 (4.68 KB, patch)
2016-12-22 12:43 UTC, Klaus Aehlig 		aehlig: maintainer-approval+
Details | Diff
Updated patch to update devel/bazel to 0.4.3 (5.30 KB, patch)
2016-12-26 18:59 UTC, Klaus Aehlig 		no flags Details | Diff
Updated patch to update devel/bazel to 0.4.3 (5.27 KB, patch)
2017-01-02 19:41 UTC, Klaus Aehlig 		no flags Details | Diff
Updated patch to update devel/bazel to 0.4.3 (5.26 KB, patch)
2017-01-09 22:15 UTC, Klaus Aehlig 		aehlig: maintainer-approval+
Details | Diff
patch to be applied to devel/bazel to update to 0.4.4 (6.07 KB, patch)
2017-01-27 21:27 UTC, Klaus Aehlig 		aehlig: maintainer-approval+
Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Klaus Aehlig 2016-12-22 12:43:13 UTC 
Created attachment 178203 [details]
Patch to update bazel to 0.4.3

Update devel/bazel to 0.4.3

While there, also change bazel to search for its rc-file
in ${ETCDIR} and provide a sample rc-file (this is the upstream
recommended rc file with persistent java workers disabled as they
do not work reliably ob FreeBSD).

- newly added file: pkg-plist
- removed files (patches are upstream)
  - files/patch-src_main_cpp_blaze__util__freebsd.cc
  - files/patch-src_main_cpp_util_file__platform.h
  - files/patch-third__party_protobuf_3.0.0_BUILD

Release notes: https://github.com/bazelbuild/bazel/releases/tag/0.4.3
Comment 2 Klaus Aehlig 2016-12-26 18:59:55 UTC 
Created attachment 178296 [details]
Updated patch to update devel/bazel to 0.4.3

The failure of 11 and 12 looks like a missing #include; I've
extended the port-update patch by an additional file  files/patch-third__party_ijar_platform__utils.cc. The port is already marked as
broken for FreeBSD 9.
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2016-12-28 12:31:57 UTC 
testbuilds of the new patch @work
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2016-12-28 16:15:04 UTC 
(In reply to Kurt Jaeger from comment #3)
still fails:

http://people.freebsd.org/~pi/logs/devel__bazel-cur-1482926427.txt
analog link for 11a.
Comment 5 Klaus Aehlig 2017-01-02 19:41:09 UTC 
Created attachment 178460 [details]
Updated patch to update devel/bazel to 0.4.3

Thanks for the test runs and sorry for the broken patch; the includes were missing in the header file, not the .cc file. Modified the patch accordingly (unfortunately, at the moment I only have a stable/10 system at hand, so couldn't properly test on the systems where the build failed).
Comment 6 Klaus Aehlig 2017-01-09 22:15:23 UTC 
Created attachment 178683 [details]
Updated patch to update devel/bazel to 0.4.3

Finally had the opportunity to verify my modified patch on stable/11, and it works. While there, I also refreshed the patch to take the removal of BROKEN_FreeBSD_9 (svn revision 430235) into account.
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2017-01-13 18:51:41 UTC 
Applying this yields:

fc$ svn patch /tmp/baz
U         bazel/Makefile
U         bazel/distinfo
Skipped 'bazel/files/patch-src_main_cpp_blaze__util__freebsd.cc'
Skipped 'bazel/files/patch-src_main_cpp_util_file__platform.h'
A         bazel/files/patch-third__party_ijar_platform__utils.h
Skipped 'bazel/files/patch-third__party_protobuf_3.0.0_BUILD'
A         bazel/pkg-plist
Summary of conflicts:
  Skipped paths: 3

Any idea ?
Comment 8 Kurt Jaeger freebsd_committer freebsd_triage 2017-01-13 18:52:57 UTC 
Ah, it's my messed-up svn repo, sorry.
Comment 9 Klaus Aehlig 2017-01-27 21:27:44 UTC 
Created attachment 179360 [details]
patch to be applied to devel/bazel to update to 0.4.4

By now, the first release candidate for bazel 0.4.4 was created,
see https://storage.googleapis.com/bazel/0.4.4/rc1/index.html
As no issues have been reported, this release candidate will
likely be promoted to 0.4.4 release.

So it might be worth considering updating directly to 0.4.4.
This patch updates the devel/bazel port to 0.4.4rc1.
As the other patch, it also changes bazel to search for its
rc-file in ${ETCDIR} (rather than hard-coded /etc) and provides
a sample rc-file (this is the upstream recommended rc file with
persistent java workers disabled as they do not work reliably
ob FreeBSD).
Comment 10 Klaus Aehlig 2017-02-01 20:11:08 UTC 
The first release candidate for Bazel 0.4.4 has been
promoted unchanged to release; release notes:
https://github.com/bazelbuild/bazel/releases/tag/0.4.4
Comment 11 Kurt Jaeger freebsd_committer freebsd_triage 2017-02-01 20:28:30 UTC 
Thanks, testbuilds@work
Comment 12 Kurt Jaeger freebsd_committer freebsd_triage 2017-02-02 06:34:28 UTC 
Committed, thanks!
Comment 13 commit-hook freebsd_committer freebsd_triage 2017-02-02 06:36:02 UTC 
A commit references this bug:

Author: pi
Date: Thu Feb  2 06:35:28 UTC 2017
New revision: 433122
URL: https://svnweb.freebsd.org/changeset/ports/433122

Log:
  devel/bazel: update 0.4.2r -> 0.4.4

  PR:		215490
  Changes:	https://github.com/bazelbuild/bazel/releases
  Submitted by:	Klaus Aehlig <aehlig@linta.de> (maintainer)

Changes:
  head/devel/bazel/Makefile
  head/devel/bazel/distinfo
  head/devel/bazel/files/patch-scripts_bootstrap_bootstrap.sh
  head/devel/bazel/files/patch-src_main_cpp_blaze__util__freebsd.cc
  head/devel/bazel/files/patch-src_main_cpp_util_file__platform.h
  head/devel/bazel/files/patch-third__party_protobuf_3.0.0_BUILD
  head/devel/bazel/pkg-plist