Created attachment 178429 [details] s6-networking-2.2.1.0 s6-networking is a suite of small networking utilities for Unix systems. It includes command-line client and server management, TCP access control, privilege escalation across UNIX domain sockets, IDENT protocol management and clock synchronization. Optionally, it also includes command-line TLS/SSL tools for secure communications. If the underlying skalibs has been compiled with IPv6 support, s6-networking is IPv6-ready.
Hi Roman, Everything I said on 215694 applies here too. Additionally, you should add the following to the s6-networking Makefile since the tls support needs a newer version of skalibs than any of the other s6-networking dependencies. BUILD_DEPENDS+= skalibs>=2.4.0.2:devel/skalibs Thanks for doing this!
One other thing, if you're adding TLS support to s6-networking you'll need to adjust CONFIGURE_ARGS to have --enable-ssl= and pick either libressl or bearssl. I'd personally suggest bearssl since it has no dependencies and can be installed alongside libressl or openssl without any issues. Whichever you pick though, make sure you set an explicit build and (if necessary) library dependency on the ssl library of choice. As it stand the current CONFIgURE_ARGS mean you'll static link against whichever ssl backend you choose so as mentioned earlier, the LIBRARY_DEPENDS line doesn't matter too much.
portlint -A complains: > # portlint -A > WARN: Makefile: [0]: possible direct use of command "strip" found. use ${STRIP_CMD} instead. > WARN: Makefile: [0]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead. > WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .4 in libskarnet.so>=2.4 unless it is really necessary. > WARN: Makefile: LIB_DEPENDS the new format is libFOO.so (e.g., liblibskarnet.so>=2.4.so).
If ssl support is added, this should be added with using USES= ssl with the variables needed set. The *_DEPENDS should not have the append flag. Instead should be something like: LIB_DEPENDS= foo.so:devel/foo \ <tab> bar.so:devel/bar and so on. Consider ssl, shared and anything else that isn't strictly reqired by the port as options. Is the do-install target really necessary? Can simply adding MAKE_ARGS and MAKE_ENV do the trick?
I'm inclined to close this given the lack of submitter feedback and since it doesn't build anymore with the newer skalibs we have in the ports tree. Roman, if this is still relevant please update.