Bug 215941 - [maintainer update] lang/nim: Update to 0.16.0
Summary: [maintainer update] lang/nim: Update to 0.16.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kirill Ponomarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-10 14:34 UTC by Neal Nelson
Modified: 2017-02-10 10:20 UTC (History)
2 users (show)

See Also:
ports: maintainer-feedback+

Attachments
Port diff. (4.24 KB, patch)
2017-01-10 14:34 UTC, Neal Nelson 		no flags Details | Diff
Makefile diff to build nimble (822 bytes, patch)
2017-01-25 06:35 UTC, Felix Hanley 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Neal Nelson 2017-01-10 14:34:13 UTC 
Created attachment 178714 [details]
Port diff.

Update lang/nim: Update to 0.16.0

One file needs to be deleted:
- svn rm files/patch-lib-pure-os.nim
Comment 1 Neal Nelson 2017-01-10 14:44:44 UTC 
Please consider committing bug #215304 which is the nimble package manager for this version of nim.
Comment 2 Felix Hanley 2017-01-25 06:34:51 UTC 
In addition to the single file deletion it should be a simple matter to also build the nimble tool to allow package management out of the box.
Comment 3 Felix Hanley 2017-01-25 06:35:49 UTC 
Created attachment 179302 [details]
Makefile diff to build nimble

Added Makefile diff to build nimble. plist and install will also need to be updated.
Comment 4 Felix Hanley 2017-01-25 06:37:47 UTC 
But bug #215304 would also suffice ;-)
Comment 5 Kirill Ponomarev freebsd_committer freebsd_triage 2017-02-09 10:53:45 UTC 
The latest patch fails to apply:

===>  Patching for nim-0.16.0
===>  Applying FreeBSD patches for nim-0.16.0
1 out of 1 hunks failed--saving rejects to lib/pure/os.nim.rej
=> FreeBSD patch patch-lib-pure-os.nim failed to apply cleanly.
=> Patch(es)  patch-build.sh patch-compiler-nimconf.nim patch-config-nim.cfg patch-install.sh applied cleanly.
*** Error code 1

Please apply new patch and remove the old one. Thanks.
Comment 6 Neal Nelson 2017-02-09 11:26:28 UTC 
As stated in the original comments: One file needs to be deleted:
- svn rm files/patch-lib-pure-os.nim

This patch is no longer needed.
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-02-10 10:19:35 UTC 
A commit references this bug:

Author: krion
Date: Fri Feb 10 10:19:26 UTC 2017
New revision: 433790
URL: https://svnweb.freebsd.org/changeset/ports/433790

Log:
  Update lang/nim to 0.16.0

  PR:		215941
  Submitted by:	maintainer
  Approved by:	mat (mentor)
  Differential Revision:	https://reviews.freebsd.org/D9509

Changes:
  head/lang/nim/Makefile
  head/lang/nim/distinfo
  head/lang/nim/files/patch-install.sh
  head/lang/nim/files/patch-lib-pure-os.nim
  head/lang/nim/pkg-plist