Bug 216027 - devel/gdb makefile can not be used if you are using gcc
Summary: devel/gdb makefile can not be used if you are using gcc
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-13 11:39 UTC by Julian Elischer
Modified: 2017-02-14 10:42 UTC (History)
2 users (show)

See Also:
luca.pizzamiglio: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Elischer freebsd_committer 2017-01-13 11:39:31 UTC
there was a test for > 1000010 but that is an error because one can use gdb after that date and some architectures require it.

that was recenty removed so now you unconditionally get   -Wno-extended-offsetof
which gcc does not support.
Comment 1 luca.pizzamiglio 2017-01-13 17:05:30 UTC
The test for > 1000010 is now changed and and the check is performed on architecture, like MIPS that still use gcc. Both checks are not optimal.
I think it's better to check the compiler type, instead of the architecture.

I'll prepare a patch to identify the compiler and act accordingly.
Comment 2 commit-hook freebsd_committer 2017-02-14 10:29:48 UTC
A commit references this bug:

Author: olivier
Date: Tue Feb 14 10:29:38 UTC 2017
New revision: 434072
URL: https://svnweb.freebsd.org/changeset/ports/434072

Log:
  Update to 7.12.1
  Updating gdb to the last stable version and cleaning it up.

  PR:		217090
  Submitted by:	luca.pizzamiglio@gmail.com (maintainer)

  PR:		216027
    - Recognizing the compiler to adopt options properly
    Reported by:   julian@FreeBSD.org

  PR:		216132
    - Fixing the segmentation fault, but arm core dump not yet usable
    Reported by:   Mark Millard

Changes:
  head/devel/gdb/Makefile
  head/devel/gdb/distinfo
  head/devel/gdb/files/patch-gdb-corelow.c
Comment 3 Olivier Cochard freebsd_committer 2017-02-14 10:31:57 UTC
Can we close this PR now?
Comment 4 luca.pizzamiglio 2017-02-14 10:34:58 UTC
(In reply to Olivier Cochard from comment #3)

Yes, we can close this PR now.
Comment 5 Olivier Cochard freebsd_committer 2017-02-14 10:42:29 UTC
Thanks!