Bug 216131 - [PATCH] Add snd_uaudio(4) support for S/PDIF output with C-Media CM6206 devices
Summary: [PATCH] Add snd_uaudio(4) support for S/PDIF output with C-Media CM6206 devices
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 11.0-RELEASE
Hardware: Any Any
: --- Affects Some People
Assignee: Hans Petter Selasky
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-01-16 06:44 UTC by Julien Nadeau
Modified: 2017-03-14 15:26 UTC (History)
2 users (show)

See Also:

Attachments
CM6206 spdif out patch (2.27 KB, patch)
2017-01-16 06:44 UTC, Julien Nadeau 		no flags Details | Diff
CM6206 spdif out patch (revised) (2.70 KB, patch)
2017-01-16 10:51 UTC, Julien Nadeau 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Nadeau 2017-01-16 06:44:50 UTC 
Created attachment 178945 [details]
CM6206 spdif out patch

This patch adds support for S/PDIF output with USB sound devices which are based
on the C-Media CM6206 chipset. This includes such devices as "Startech 7.1 USB
adapter".
Comment 1 Hans Petter Selasky freebsd_committer freebsd_triage 2017-01-16 09:02:23 UTC 
Hi,

Can you also include the usbdevs diff?

error: use of undeclared identifier
      'USB_PRODUCT_CMEDIA_CM6206'
            (uaa->info.idProduct == USB_PRODUCT_CMEDIA_CM6206)) {

--HPS
Comment 2 Julien Nadeau 2017-01-16 10:51:57 UTC 
Created attachment 178947 [details]
CM6206 spdif out patch (revised)

Original patch was missing the usbdevs entry
Comment 3 Julien Nadeau 2017-01-16 10:53:20 UTC 
(In reply to Hans Petter Selasky from comment #1)
Sorry about that; revised patch including usbdevs is attached.
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-01-17 08:15:48 UTC 
A commit references this bug:

Author: hselasky
Date: Tue Jan 17 08:15:11 UTC 2017
New revision: 312338
URL: https://svnweb.freebsd.org/changeset/base/312338

Log:
  Add USB audio support for S/PDIF output with C-Media CM6206 devices.

  Submitted by:		Julien Nadeau <vedge@hypertriton.com>
  PR:			216131
  MFC after:		1 week

Changes:
  head/share/man/man4/usb_quirk.4
  head/sys/dev/sound/usb/uaudio.c
  head/sys/dev/usb/quirk/usb_quirk.c
  head/sys/dev/usb/quirk/usb_quirk.h
  head/sys/dev/usb/usbdevs
Comment 5 Hans Petter Selasky freebsd_committer freebsd_triage 2017-01-17 08:18:28 UTC 
Hi,

Your patch has been submitted with some modifications.

The usb_quirk kernel module is used to keep track of the new functionality.

Make sure usb_quirk.ko is loaded or in the kernel before testing.

Please test the submitted patch as referred by this PR.

Re-open if you find any bugs.

Thank you!

--HPS
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-03-14 15:20:37 UTC 
A commit references this bug:

Author: hselasky
Date: Tue Mar 14 15:19:15 UTC 2017
New revision: 315248
URL: https://svnweb.freebsd.org/changeset/base/315248

Log:
  MFC r312338:

  Add USB audio support for S/PDIF output with C-Media CM6206 devices.

  Submitted by:		Julien Nadeau <vedge@hypertriton.com>
  PR:			216131

Changes:
_U  stable/11/
  stable/11/share/man/man4/usb_quirk.4
  stable/11/sys/dev/sound/usb/uaudio.c
  stable/11/sys/dev/usb/quirk/usb_quirk.c
  stable/11/sys/dev/usb/quirk/usb_quirk.h
  stable/11/sys/dev/usb/usbdevs
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-03-14 15:22:41 UTC 
A commit references this bug:

Author: hselasky
Date: Tue Mar 14 15:21:41 UTC 2017
New revision: 315249
URL: https://svnweb.freebsd.org/changeset/base/315249

Log:
  MFC r312338:

  Add USB audio support for S/PDIF output with C-Media CM6206 devices.

  Submitted by:		Julien Nadeau <vedge@hypertriton.com>
  PR:			216131

Changes:
_U  stable/10/
  stable/10/share/man/man4/usb_quirk.4
  stable/10/sys/dev/sound/usb/uaudio.c
  stable/10/sys/dev/usb/quirk/usb_quirk.c
  stable/10/sys/dev/usb/quirk/usb_quirk.h
  stable/10/sys/dev/usb/usbdevs
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-03-14 15:26:46 UTC 
A commit references this bug:

Author: hselasky
Date: Tue Mar 14 15:25:50 UTC 2017
New revision: 315250
URL: https://svnweb.freebsd.org/changeset/base/315250

Log:
  MFC r312338:

  Add USB audio support for S/PDIF output with C-Media CM6206 devices.

  Submitted by:		Julien Nadeau <vedge@hypertriton.com>
  PR:			216131

Changes:
_U  stable/9/share/
_U  stable/9/share/man/
_U  stable/9/share/man/man4/
  stable/9/share/man/man4/usb_quirk.4
_U  stable/9/sys/
  stable/9/sys/dev/sound/usb/uaudio.c
  stable/9/sys/dev/usb/quirk/usb_quirk.c
  stable/9/sys/dev/usb/quirk/usb_quirk.h
  stable/9/sys/dev/usb/usbdevs