Bug 216571 - audio/sndio: Various fixes
Summary: audio/sndio: Various fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlos J. Puga Medina
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2017-01-29 13:31 UTC by Tobias Kortkamp
Modified: 2017-02-01 17:05 UTC (History)
1 user (show)

See Also:


Attachments
audio___sndio.diff (6.22 KB, patch)
2017-01-29 13:31 UTC, Tobias Kortkamp
tobik: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2017-01-29 13:31:36 UTC
Created attachment 179395 [details]
audio___sndio.diff

- Success in opening /dev/dsp* O_RDWR does not mean the device
  supports play/recording.  Add an extra check to see if the requested
  mode is really supported.
- Sndiod cannot currently be started in jails as root, because it
  tries to setpriority(-20).  Allow setpriority to fail and start the
  daemon anyway.
- Fallback to /dev/dsp instead of /dev/dsp0 when using libsndio directly
  without a running sndiod
- Implement sio_setvol in the OSS backend for application level volume
  control with just libsndio

Portlint: ok
Synth test log: https://pkg.tobik.me/logs/audio___sndio.log
Comment 1 Carlos J. Puga Medina freebsd_committer 2017-02-01 16:21:23 UTC
Take
Comment 2 commit-hook freebsd_committer 2017-02-01 17:04:56 UTC
A commit references this bug:

Author: cpm
Date: Wed Feb  1 17:04:29 UTC 2017
New revision: 433052
URL: https://svnweb.freebsd.org/changeset/ports/433052

Log:
  audio/sndio: Various fixes

  - Success in opening /dev/dsp* O_RDWR does not mean the device
    supports play/recording.  Add an extra check to see if the requested
    mode is really supported.
  - sndiod cannot currently be started in jails as root, because it
    tries to setpriority(-20).  Allow setpriority to fail and start the
    daemon anyway.
  - Fallback to /dev/dsp instead of /dev/dsp0 when using libsndio directly
    without a running sndiod.
  - Implement sio_setvol in the OSS backend for application level volume
    control with just libsndio.

  PR:		216571
  Submitted by:	Tobias Kortkamp <t@tobik.me> (maintainer)

Changes:
  head/audio/sndio/Makefile
  head/audio/sndio/files/patch-libsndio_sio.c
  head/audio/sndio/files/patch-libsndio_sio__oss.c
  head/audio/sndio/pkg-message
Comment 3 Carlos J. Puga Medina freebsd_committer 2017-02-01 17:05:45 UTC
Committed!

Thanks