Bug 216591 - Mk/bsd.xorg.mk: support :build
Summary: Mk/bsd.xorg.mk: support :build
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on: 238988
Blocks:
  Show dependency tree / graph
 
Reported: 2017-01-30 01:27 UTC by John Hein
Modified: 2020-07-11 20:04 UTC (History)
3 users (show)

See Also:

Attachments
[patch] add :build support to bsd.xorg.mk (912 bytes, patch)
2017-01-30 01:27 UTC, John Hein 		no flags Details | Diff
[patch] [v2] add :build support to bsd.xorg.mk (927 bytes, patch)
2017-01-30 16:36 UTC, John Hein 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2017-01-30 01:27:19 UTC 
Created attachment 179413 [details]
[patch] add :build support to bsd.xorg.mk

There's a few places in the tree including bsd.xorg.mk itself that expected USE_XORG to support a :build option for components.  As far as I can see, the infrastructure never has supported it.

Attached is a patch to not include :build components in RUN_DEPENDS.

There are probably a number of cases in the tree that could/should use :build for xorg components, but that's a followup exercise enabled by this patch.
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2017-01-30 09:09:46 UTC 
over to maintainer
Comment 2 John Hein 2017-01-30 16:36:13 UTC 
Created attachment 179430 [details]
[patch] [v2] add :build support to bsd.xorg.mk

Fix patch - remove extra brace level.
Comment 3 Niclas Zeising freebsd_committer freebsd_triage 2019-09-20 14:43:59 UTC 
Hi!
I'm not sure :build is actually needed.  Almost all things in Uses/xorg.mk are libraries, which would be both build- and runtime needed anyway.
Comment 4 Niclas Zeising freebsd_committer freebsd_triage 2020-07-11 20:04:15 UTC 
Thank you for the submission!
I don't think we need a :build in the USES=xorg infrastructure.  Almost everything there is shared libraries which are going to be needed at runtime, and no port today, as far as I know, needs any xorg component at runtime unless it's already in the xorg infra.