Created attachment 179451 [details] Update multimedia/ffmpegthumbnailer to 2.2.0. This drops files/patch-CMakeLists.txt which was fixed upstream. FFmpegThumbnailer 2.2.0 - New option to prefer embedded image metadata over video content (command line argument: -m) - Fixed 'Resource temporarily unavailable' errors when using ffmpeg < 3.0 FFmpegThumbnailer 2.1.2 - Restored deinterlace functionality using the libavfilter library (additional ffmpeg dependency) - Additional video mime types added to the thumbnailer file - Take rotation metadata into account when generating thumbnails
Compiles fine. Thank you. Are those lines necessary?: GH_PROJECT= ffmpegthumbnailer GH_SUBDIR= src/github.com/dirkvdb/ffmpegthumbnailer It works without them.
(In reply to clutton from comment #1) Whether those lines are necessary or not, I can't say. In an unrelated port submission of mine they were added in and I've not trolled through the Mk bits to see if they serve a secret purpose, if it's considered good form, or was just the approvers preference.
Mk/bsd.sites.mk # GH_PROJECT - name of the project on GitHub # default: ${PORTNAME} we can skip this then. # GH_SUBDIR - directory relative to WRKSRC where to move this distfile's # content after extracting. My guess is that this is for different extracted dir. We have OK extracted dir. You can safely remove those lines. No need to overengineering, just using defaults would be ok.
Created attachment 179484 [details] Update multimedia/ffmpegthumbnailer to 2.2.0. Drop files/patch-CMakeLists.txt, remove extraneous GH Makefile options.
approved.
my feedback is: ok, finished, please accept.
A commit references this bug: Author: riggs Date: Sat Mar 4 15:06:49 UTC 2017 New revision: 435411 URL: https://svnweb.freebsd.org/changeset/ports/435411 Log: Update to upstream version 2.2.0 Detailed log: - New option to prefer embedded image metadata over video content (command line argument: -m) - Fixed 'Resource temporarily unavailable' errors when using ffmpeg < 3.0 - Restored deinterlace functionality using the libavfilter library (additional ffmpeg dependency) - Additional video mime types added to the thumbnailer file - Take rotation metadata into account when generating thumbnails PR: 216648 Submitted by: stl@ossuary.net Approved by: clutton@zoho.com (maintainer) MFH: 2017Q1 Changes: head/multimedia/ffmpegthumbnailer/Makefile head/multimedia/ffmpegthumbnailer/distinfo head/multimedia/ffmpegthumbnailer/files/patch-CMakeLists.txt head/multimedia/ffmpegthumbnailer/pkg-plist
A commit references this bug: Author: riggs Date: Sun Mar 5 09:02:04 UTC 2017 New revision: 435460 URL: https://svnweb.freebsd.org/changeset/ports/435460 Log: MFH: r435411 Update to upstream version 2.2.0 Detailed log: - New option to prefer embedded image metadata over video content (command line argument: -m) - Fixed 'Resource temporarily unavailable' errors when using ffmpeg < 3.0 - Restored deinterlace functionality using the libavfilter library (additional ffmpeg dependency) - Additional video mime types added to the thumbnailer file - Take rotation metadata into account when generating thumbnails PR: 216648 Submitted by: stl@ossuary.net Approved by: ports-secteam (junovitch), clutton@zoho.com (maintainer) Changes: _U branches/2017Q1/ branches/2017Q1/multimedia/ffmpegthumbnailer/Makefile branches/2017Q1/multimedia/ffmpegthumbnailer/distinfo branches/2017Q1/multimedia/ffmpegthumbnailer/files/patch-CMakeLists.txt branches/2017Q1/multimedia/ffmpegthumbnailer/pkg-plist
Exp-run flag was touched by mistake.