Bug 216651 - games/njam: fails to build with libc++ 4.0
Summary: games/njam: fails to build with libc++ 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency tree / graph
 
Reported: 2017-01-31 01:39 UTC by Jan Beich
Modified: 2017-02-01 14:49 UTC (History)
1 user (show)

See Also:
amdmi3: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2017-01-31 01:39:00 UTC 
In file included from njam.cpp:41:
In file included from /usr/include/c++/v1/string:469:
/usr/include/c++/v1/__config:132:10: fatal error: 'features.h' file not found
#include <features.h>
         ^~~~~~~~~~~~

build log: http://package18.nyi.freebsd.org/data/headamd64PR216008-default/2017-01-29_16h09m05s/logs/errors/njam-1.25_12.log
regressed by: https://github.com/llvm-mirror/libcxx/commit/7d7f3cc9b169
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2017-02-01 11:37:16 UTC 
It doesn't seem to be related to port. The problematic include is in standard library.
Comment 2 Jan Beich freebsd_committer freebsd_triage 2017-02-01 12:10:25 UTC 
Maybe drop -D__linux__ from the port as it's a recipe to break system headers.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2017-02-01 14:27:21 UTC 
Oh, you're right. On it.
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-02-01 14:41:54 UTC 
A commit references this bug:

Author: amdmi3
Date: Wed Feb  1 14:40:48 UTC 2017
New revision: 433038
URL: https://svnweb.freebsd.org/changeset/ports/433038

Log:
  - Fix build with clang 4.0 by not defining __linux__
  - Add LICENSE
  - Switch to options helpers
  - Regenerate patches

  PR:		216651
  Submitted by:	jbeich@FreeBSD.org

Changes:
  head/games/njam/Makefile
  head/games/njam/files/patch-src_njamedit.cpp
Comment 5 Jan Beich freebsd_committer freebsd_triage 2017-02-01 14:49:25 UTC 
I confirm, it builds fine now with clang/libc++ 4.0.