Bug 216653 - lang/php70: pet portlint
Summary: lang/php70: pet portlint
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Torsten Zuehlsdorff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-31 02:56 UTC by Mark Linimon
Modified: 2017-02-01 16:36 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (tz)


Attachments
patch to lang/php70/Makefile (611 bytes, patch)
2017-01-31 02:56 UTC, Mark Linimon
no flags Details | Diff
corrected diff (532 bytes, patch)
2017-01-31 03:04 UTC, Mark Linimon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Linimon freebsd_committer freebsd_triage 2017-01-31 02:56:57 UTC
Created attachment 179456 [details]
patch to lang/php70/Makefile

php70 does not build on aarch64 (aka arm64).  I'm not sure of the reason.  However, there is no reason for the package builders to keep trying to build it in the meantime.

While testing this patch I made one more change to appease portlint.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2017-01-31 03:03:04 UTC
Actually as of 431960 it builds on aarch64, so this is a stale patch.

However, the portlint part is still correct.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2017-01-31 03:04:46 UTC
Created attachment 179457 [details]
corrected diff
Comment 3 commit-hook freebsd_committer 2017-02-01 16:25:21 UTC
A commit references this bug:

Author: tz
Date: Wed Feb  1 16:24:56 UTC 2017
New revision: 433044
URL: https://svnweb.freebsd.org/changeset/ports/433044

Log:
  lang/php70: pet portlint by moving LIB_DEPENDS up

  PR:           216653
  Submitted by: linimon

Changes:
  head/lang/php70/Makefile
Comment 4 Torsten Zuehlsdorff freebsd_committer 2017-02-01 16:30:25 UTC
Committed, thanks for the patch!
Comment 5 commit-hook freebsd_committer 2017-02-01 16:36:32 UTC
A commit references this bug:

Author: tz
Date: Wed Feb  1 16:35:43 UTC 2017
New revision: 433046
URL: https://svnweb.freebsd.org/changeset/ports/433046

Log:
  lang/php71: pet portlint by moving LIB_DEPENDS up

  Convert the patch from lang/php70 to lang/php71

  PR:           216653
  Submitted by: linimon

Changes:
  head/lang/php71/Makefile