Bug 216668 - [PATCH] expand EXTRA_PATCH_TREE functionality to Makefile.local
Summary: [PATCH] expand EXTRA_PATCH_TREE functionality to Makefile.local
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Port Management Team
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-01-31 05:17 UTC by Andre Albsmeier
Modified: 2017-01-31 11:10 UTC (History)
1 user (show)

See Also:


Attachments
Additionally seatch in EXTRA_PATCH_TREE for Makefile.local (484 bytes, patch)
2017-01-31 05:17 UTC, Andre Albsmeier
no flags Details | Diff
Additionally search in EXTRA_MAKEFILE_LOCAL_TREE for Makefile.local (511 bytes, patch)
2017-01-31 11:09 UTC, Andre Albsmeier
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andre Albsmeier 2017-01-31 05:17:11 UTC
Created attachment 179465 [details]
Additionally seatch in EXTRA_PATCH_TREE for Makefile.local

https://svnweb.freebsd.org/ports?view=revision&revision=431681
added the EXTRA_PATCH_TREE feature. I would like to suggest to deal with
Makefile.local the same way (additionally searching them in the EXTRA_PATCH_TREE).
This way Makefile.local could stay out of the regular ports tree as well.

The patch attached is a suggestion for this. There are no changes for people not
using Makefile.local in EXTRA_PATCH_TREE.
Comment 1 Mathieu Arnold freebsd_committer 2017-01-31 09:31:32 UTC
I don't like the idea of abusing a variable for what it was not made, and named, for. Please use a new variable.
Comment 2 Andre Albsmeier 2017-01-31 11:09:43 UTC
Created attachment 179469 [details]
Additionally search in EXTRA_MAKEFILE_LOCAL_TREE for Makefile.local

Now using EXTRA_MAKEFILE_LOCAL_TREE instead of EXTRA_PATCH_TREE.
Comment 3 Andre Albsmeier 2017-01-31 11:10:00 UTC
better now?