Bug 216972 - sysutils/farbot: new MASTER_SITES, updates version, take MAINTAINER'ship
Summary: sysutils/farbot: new MASTER_SITES, updates version, take MAINTAINER'ship
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nikolai Lifanov
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2017-02-10 17:38 UTC by Chris Hutchinson
Modified: 2017-02-16 20:47 UTC (History)
1 user (show)

See Also:

Attachments
patch (svn diff) for sysutils/farbot (4.45 KB, patch)
2017-02-10 17:38 UTC, Chris Hutchinson 		no flags Details | Diff
build log for sysutils/farbot (34.52 KB, text/plain)
2017-02-10 17:39 UTC, Chris Hutchinson 		no flags Details
alternative patch (3.76 KB, patch)
2017-02-16 20:15 UTC, Nikolai Lifanov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2017-02-10 17:38:45 UTC 
Created attachment 179842 [details]
patch (svn diff) for sysutils/farbot

this pr(1) makes the following changes to sysutils/farbot

MASTER_SITES: replaces GOOGLE with GITHUB
PORTVERSION: updates 1.0.b2 to 1.0
MAINTAINER: ports@ to me
distinfo
pkg-plist
pkg-descr: reflow, and update WWW

That's pretty much it!

Please see the svn diff sysutils_farbot.diff, and the build log
sysutils-farbot-QA-LOG, attached. For further details.

Thanks!

--Chris
Comment 1 Chris Hutchinson 2017-02-10 17:39:43 UTC 
Created attachment 179843 [details]
build log for sysutils/farbot
Comment 2 Nikolai Lifanov freebsd_committer freebsd_triage 2017-02-16 19:23:45 UTC 
I'll try to get in touch with original maintainer.
Comment 3 Nikolai Lifanov freebsd_committer freebsd_triage 2017-02-16 19:25:04 UTC 
Ha ha, whoops, should have looked at the diff first!
Comment 4 Nikolai Lifanov freebsd_committer freebsd_triage 2017-02-16 19:49:05 UTC 
Can we USE_PYTHON autoplist for this?
Comment 5 Nikolai Lifanov freebsd_committer freebsd_triage 2017-02-16 20:06:38 UTC 
distinfo is missing TIMESTAMP, but otherwise it's OK
Comment 6 Nikolai Lifanov freebsd_committer freebsd_triage 2017-02-16 20:08:01 UTC 
Sorry, commented on wrong bug :)
Comment 7 Nikolai Lifanov freebsd_committer freebsd_triage 2017-02-16 20:14:55 UTC 
I have a couple of other plist-related comments:

%%ETCDIR%% should refer to a directory, but refer to a string component in etc/farbot.conf.sample. I know "make makeplist" does this for you, but this should be expanded.

Also, since this is a .sample file, we need a @sample macro to expand this to farbot.conf on install.
Comment 8 Nikolai Lifanov freebsd_committer freebsd_triage 2017-02-16 20:15:51 UTC 
Created attachment 180057 [details]
alternative patch

Please review this and let me know if it is OK.
Comment 9 Chris Hutchinson 2017-02-16 20:26:43 UTC 
Comment on attachment 180057 [details]
alternative patch

I like it, Nikolai Lifanov.
Please use it! :-)

--Chris
Comment 10 commit-hook freebsd_committer freebsd_triage 2017-02-16 20:37:23 UTC 
A commit references this bug:

Author: lifanov
Date: Thu Feb 16 20:36:54 UTC 2017
New revision: 434252
URL: https://svnweb.freebsd.org/changeset/ports/434252

Log:
  unbreak sysutils/farbot and update to 1.0

   - update to 1.0
   - switch form GOOGLE_CODE to GITHUB
   - add LICENSE
   - switch to autoplist
   - use @sample for etc/farbot.conf.sample

  PR:		216972
  Submitted by:	Chris Hutchinson <portmaster@bsdforge.com>

Changes:
  head/sysutils/farbot/Makefile
  head/sysutils/farbot/distinfo
  head/sysutils/farbot/pkg-descr
  head/sysutils/farbot/pkg-plist
Comment 11 Nikolai Lifanov freebsd_committer freebsd_triage 2017-02-16 20:38:23 UTC 
Committed with changes, thanks!

FYI: this one was also missing TIMESTAMP in distinfo, so I added it.

So far you've been doing awesome work.
Feel free to CC me directly to bugs you would like me to take a look at.
Comment 12 Chris Hutchinson 2017-02-16 20:47:57 UTC 
(In reply to Nikolai Lifanov from comment #11)
> Committed with changes, thanks!
> 
> FYI: this one was also missing TIMESTAMP in distinfo, so I added it.
> 
> So far you've been doing awesome work.
> Feel free to CC me directly to bugs you would like me to take a look at.

That's a very kind offer, Nikolai. Thanks!

--Chris