Bug 217505 - [asmc] [patch] Add Support for Macbook Pro 8,1
Summary: [asmc] [patch] Add Support for Macbook Pro 8,1
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 11.0-RELEASE
Hardware: amd64 Any
: --- Affects Some People
Assignee: David Bright
URL:
Keywords: feature, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2017-03-02 22:13 UTC by John O. Brickley
Modified: 2018-12-20 01:12 UTC (History)
4 users (show)

See Also:
dab: mfc-stable10-
dab: mfc-stable11+
dab: mfc-stable12+


Attachments
Adds Macbook Pro 8,1 support. (12.64 KB, patch)
2017-03-02 22:13 UTC, John O. Brickley
no flags Details | Diff
asmc-mbp81.patch (3.54 KB, patch)
2018-12-11 16:17 UTC, Maciej Pasternacki
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John O. Brickley 2017-03-02 22:13:19 UTC
Created attachment 180448 [details]
Adds Macbook Pro 8,1 support.

This patch adds support for the Macbook Pro 8,1.  As with the recent patch (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=214836) for the Macbook Pro 11,2, I have disabled the SMS (Sudden Motion Sensor) since its activation currently throws errors with changes in ambient light level.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-04-30 05:04:52 UTC
CC adrian (committer of related bug 214836) who may know someone who can take care of this
Comment 2 Maciej Pasternacki 2018-12-11 16:17:09 UTC
Created attachment 200044 [details]
asmc-mbp81.patch

Updated to apply on current HEAD, correct patch direction, removed whitespace changes
Comment 3 David Bright freebsd_committer 2018-12-11 16:49:10 UTC
I'll take this and MFC to stable12 and stable11; I don't intend to MFC to stable10.
Comment 4 commit-hook freebsd_committer 2018-12-12 13:44:36 UTC
A commit references this bug:

Author: dab
Date: Wed Dec 12 13:43:56 UTC 2018
New revision: 341988
URL: https://svnweb.freebsd.org/changeset/base/341988

Log:
  asmc: Add Support for Macbook Pro 8,1

  PR:		217505
  Submitted by:	John O. Brickley <obryan.brickley@gmail.com>, updated by Maciej Pasternacki <maciej@pasternacki.net>
  Reported by:	John O. Brickley <obryan.brickley@gmail.com>
  MFC after:	1 week

Changes:
  head/sys/dev/asmc/asmc.c
  head/sys/dev/asmc/asmcvar.h
Comment 5 commit-hook freebsd_committer 2018-12-20 00:57:58 UTC
A commit references this bug:

Author: dab
Date: Thu Dec 20 00:57:24 UTC 2018
New revision: 342268
URL: https://svnweb.freebsd.org/changeset/base/342268

Log:
  MFC r341988

  asmc: Add Support for Macbook Pro 8,1

  PR:		217505
  Submitted by:	John O. Brickley <obryan.brickley@gmail.com>, updated by Maciej Pasternacki <maciej@pasternacki.net>
  Reported by:	John O. Brickley <obryan.brickley@gmail.com>

Changes:
_U  stable/12/
  stable/12/sys/dev/asmc/asmc.c
  stable/12/sys/dev/asmc/asmcvar.h
Comment 6 commit-hook freebsd_committer 2018-12-20 00:59:02 UTC
A commit references this bug:

Author: dab
Date: Thu Dec 20 00:58:16 UTC 2018
New revision: 342269
URL: https://svnweb.freebsd.org/changeset/base/342269

Log:
  MFC r341988

  asmc: Add Support for Macbook Pro 8,1

  PR:		217505
  Submitted by:	John O. Brickley <obryan.brickley@gmail.com>, updated by Maciej Pasternacki <maciej@pasternacki.net>
  Reported by:	John O. Brickley <obryan.brickley@gmail.com>

Changes:
_U  stable/11/
  stable/11/sys/dev/asmc/asmc.c
  stable/11/sys/dev/asmc/asmcvar.h
Comment 7 David Bright freebsd_committer 2018-12-20 01:12:30 UTC
MFC complete; closing.