Created attachment 180459 [details]
Four additional patch files for editors/jove
Jove used an internal function named 'getline()' to save and read its recovery file. This call was renamed get_line() by a previous port patch, but only in its definition. The code that called it was not changed, causing the stdlib getline() to be called with incorrect arguments. This broke jove's recovery function and caused core dumps.
The attached patches finsh the work by renaming the internal getline to get_line() throughout the code.
These four patch files should be added to the files directory.
Created attachment 180460 [details]
(In reply to crahman from comment #0)
> The attached patches finsh the work by renaming the internal getline to get_line() throughout the code.
How about using REINPLACE_CMD for this? Can you test the attached patch?
(In reply to Tobias Kortkamp from comment #1)
I've tested your alternative patch to the Makefile and it is correct.
Thanks for testing. Now waiting for mentor approval.
A commit references this bug:
Date: Sat Mar 4 00:03:01 UTC 2017
New revision: 435376
JOVE defines a getline function that collides with getline(3).
r419275 tried to fix it by renaming it to get_line, but a few renames
were missed leading to crashes when trying to run JOVE. Finish the
previous work and also add LICENSE while here.
Submitted by: email@example.com (based on)
Reviewed by: firstname.lastname@example.org
Approved by: mat (mentor)
Differential Revision: https://reviews.freebsd.org/D9881