Bug 217546 - [patch] multimedia/smplayer: add Qt5 option, drop qt*-script from dependencies
Summary: [patch] multimedia/smplayer: add Qt5 option, drop qt*-script from dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rusmir Dusko
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-03-04 21:04 UTC by Andriy Voskoboinyk
Modified: 2018-01-17 17:23 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (nemysis)


Attachments
The patch (4.10 KB, patch)
2017-03-04 21:04 UTC, Andriy Voskoboinyk
no flags Details | Diff
Poudriere logs (10.3-RELEASE i386, 11.0-RELEASE amd64) (27.03 KB, application/x-xz)
2017-03-04 21:17 UTC, Andriy Voskoboinyk
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer 2017-03-04 21:04:37 UTC
Created attachment 180509 [details]
The patch

- Provide a choice between Qt versions (4/5).
- Add possibility to use MPV as a backend; disable support in code when backend is not selected (mplayer2 support is always disabled).
- Add options for additional skins / themes.
- Always disable YT_USE_SCRIPT; smplayer does not have youtube support and downloaded code seems to be unused (if needed, it can be fetched via multimedia/smtube, Help -> "Update the YouTube code"); qt*-script dependency is not needed without it.
- Bump PORTREVISION.
Comment 1 Andriy Voskoboinyk freebsd_committer 2017-03-04 21:17:22 UTC
Created attachment 180510 [details]
Poudriere logs (10.3-RELEASE i386, 11.0-RELEASE amd64)

(warnings about libXext, libGL are wrong and should go away when compiled with LDFLAGS=-Wl,--as-needed + non-broken compiler (clang ignores this option))
Comment 2 commit-hook freebsd_committer 2018-01-17 17:17:47 UTC
A commit references this bug:

Author: pawel
Date: Wed Jan 17 17:17:26 UTC 2018
New revision: 459273
URL: https://svnweb.freebsd.org/changeset/ports/459273

Log:
  - Provide a choice between Qt versions (4/5).
  - Add possibility to use MPV as a backend; disable support in code when backend
    is not selected (obsolete mplayer2 support is always disabled).
  - Add options for additional skins / themes
  - Convert to options helpers

  PR:		217546
  Submitted by:	avos
  Approved by:	maintainer timeout

Changes:
  head/multimedia/smplayer/Makefile
  head/multimedia/smplayer/files/patch-src_smplayer.pro
Comment 3 Pawel Pekala freebsd_committer 2018-01-17 17:23:14 UTC
Committed without YT_USE_SCRIPT disable part because newer versions of smtube
don't have mentioned option anymore. Thanks.