Created attachment 180815 [details]
We have found and fixed a weakness using PVS-Studio tool. PVS-Studio is a static code analyzer for C, C++ and C#: https://www.viva64.com/en/pvs-studio/
Analyzer warning: V519 The 'pmuctrl' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 2025, 2026. bhnd_pmu_subr.c 2026
A commit references this bug:
Date: Wed Mar 15 18:57:19 UTC 2017
New revision: 315324
[bhnd] fix mask for PMU control
This patch fixes typo which results in extra bits of PMU control register.
Submitted by: Svyatoslav <razmyslov at viva64.com>
Found by: PVS-Studio
batch change of PRs untouched in 2018 marked "in progress" back to open.
This still needs to be evaluated for MFC
FreeBSD 10 is EOL, should we close this PR as fixed?
Does it need to go to stable/11?
(In reply to Ed Maste from comment #5)
Looks like majority of bhnd commits never has been MFCed to stable/11, so I don't think there is any point in merging this one. But I'd leave it to maintainers.
Assign to committer resolving (committed to head in base r315324)