Bug 218584 - net-mgmt/nagios-check_ports -c looks for legacy tools
Summary: net-mgmt/nagios-check_ports -c looks for legacy tools
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-12 09:29 UTC by ml
Modified: 2017-04-12 19:07 UTC (History)
2 users (show)

See Also:
ryanrfrederick: maintainer-feedback+

Attachments
Update patch to 0.7.2 (999 bytes, patch)
2017-04-12 18:31 UTC, Ryan Frederick 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ml 2017-04-12 09:29:56 UTC 
This tool seems to lag behind a bit: while it works fine, it will print
some errors when it "checks the environment".
I.e.:
> # /usr/local/libexec/nagios/check_ports -c
> checking environment ...
>
>   OK:    Your operating system is FreeBSD, main release 10.
>   ERROR: portaudit not found!
>   ERROR: pkg_version not found at /usr/sbin/pkg_version.
>          Update information will not be available!
> /usr/local/libexec/nagios/check_ports: /usr/local/sbin/portaudit: not
> found
>   OK:    portaudit database is up to date (Last Update: ).
>   OK:    jexec found at /usr/sbin/jexec
>   OK:    /usr/ports/INDEX-10 readable.

Of course, "portaudit" is gone in favour of "pkg audit" and
"pkg_"version is now "pkg version".


Again, this doesn't hamper the port's functionality.
Comment 1 Ryan Frederick 2017-04-12 16:32:02 UTC 
Working on a new upstream bugfix release. Will post port tree patch file for commit once the release is ready.
Comment 2 Ryan Frederick 2017-04-12 18:31:18 UTC 
Created attachment 181737 [details]
Update patch to 0.7.2

Patch to update the port to 0.7.2
Comment 3 Ryan Frederick 2017-04-12 18:32:36 UTC 
I've made an upstream bugfix release (0.7.2) and have attached a patch for review and commit to the Ports Tree.
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2017-04-12 18:33:03 UTC 
testbuilds@work
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2017-04-12 18:37:33 UTC 
Would LICENSE=BSD be OK ? Just to pet portlint ?
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2017-04-12 18:39:28 UTC 
Btw, testbuilds are fine and I'm replacing the pkg-plist file with:

PLIST_FILES=libexec/nagios/check_ports
Comment 7 Ryan Frederick 2017-04-12 18:47:36 UTC 
Yes, LICENSE=BSD or LICENSE=BSD2CLAUSE (script uses 2-Clause) and the pkg-plist replacement are okay.
Comment 8 Kurt Jaeger freebsd_committer freebsd_triage 2017-04-12 19:06:44 UTC 
Committed, thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2017-04-12 19:07:03 UTC 
A commit references this bug:

Author: pi
Date: Wed Apr 12 19:06:39 UTC 2017
New revision: 438405
URL: https://svnweb.freebsd.org/changeset/ports/438405

Log:
  net-mgmt/nagios-check_ports: update 0.7.1 -> 0.7.2

  - handle newer pkg commands like pkg audit and pkg version
  - pet portlint with LICENSE

  PR:		218584
  Reported by:	ml@netfence.it
  Submitted by:	Ryan Frederick <ryanrfrederick@gmail.com> (maintainer)

Changes:
  head/net-mgmt/nagios-check_ports/Makefile
  head/net-mgmt/nagios-check_ports/distinfo
  head/net-mgmt/nagios-check_ports/pkg-plist