Bug 218830 - [cam] [patch] add CAM pass(4) support for NVMe
Summary: [cam] [patch] add CAM pass(4) support for NVMe
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-scsi (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-04-23 17:16 UTC by chuck
Modified: 2018-05-25 19:16 UTC (History)
4 users (show)

See Also:
emaste: mfc-stable11?


Attachments
patch to add NVMe support to pass (4.46 KB, patch)
2017-04-23 17:16 UTC, chuck
no flags Details | Diff
Updated patch based on review comments (7.77 KB, patch)
2017-06-25 19:04 UTC, chuck
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chuck 2017-04-23 17:16:44 UTC
Created attachment 182021 [details]
patch to add NVMe support to pass

This patch adds IO pass-through support for NVMe to CAM for both administrative and NVM (a.k.a. "IO") commands. To differentiate between the command types, the patch adds a new function code XPT_NVME_ADMIN for administrative commands and uses the existing function code for NVM commands.

Code reviewed https://reviews.freebsd.org/D10247
Comment 1 chuck 2017-06-25 19:04:11 UTC
Created attachment 183788 [details]
Updated patch based on review comments

Updates the patch to address comments made in review https://reviews.freebsd.org/D10247
Comment 2 Ed Maste freebsd_committer freebsd_triage 2017-07-27 01:16:20 UTC
Committed in r320984 it seems?
https://reviews.freebsd.org/rS320984
Comment 3 Kenneth D. Merry freebsd_committer freebsd_triage 2017-07-27 13:40:38 UTC
Yes, it has been committed.  Do we want to MFC it to stable/11?
Comment 4 Ed Maste freebsd_committer freebsd_triage 2017-07-27 13:55:47 UTC
> Yes, it has been committed.  Do we want to MFC it to stable/11?

That seems reasonable to me, given that NVMe is going to continue to become more popular.
Comment 5 chuck 2018-02-26 15:42:46 UTC
I believe mav@ MFC'd this in r328680 and this can be closed.