Here are some minor improvements to this port.
* Removal of unneeded dependencies libcurl and docbook-xml. I think the CouchPotato README is not up-to-date for the FreeBSD dependencies.
* Addition of py-lxml, see message from log below
LXML not available, please install for better/faster scraping support: `http://lxml.de/installation.html`
* Addition of py-openssl, see message from log below
OpenSSL not available, please install for better requests validation: `https://pyopenssl.readthedocs.org/en/latest/install.html`: Traceback (most recent call last): File "/usr/local/share/couchpotato/couchpotato/core/_base/_core.py", line 84, in dependencies import OpenSSL ImportError: No module named OpenSSL
* Limit python to versions 2.6 and 2.7
* No need to hardcode service user in init script
* Add optional dependency unrar, see CouchPotato > Renamer (advanced) > Unrar
Created attachment 182033 [details]
Would you like to take maintainership of this port? I no longer use it as I have migrated to Radarr.
(In reply to Mark Felder from comment #2)
Sure, I'm fine taking it over if you like. I do still use CouchPotato and would be willing review any bugs/requests.
If you want feel free to replace your email with mine in the diff, maybe we should also bump the PORTREVISION.
Yes, portrevision should be bumped.
Critique of the patch:
python:2.6-2.7 is pointless because FreeBSD doesn't support python 2.6 for a long time. I will just make it python:2.7
rc script hardcoded user was intentional as it can't be overridden at build time in its current state, but your change is harmless
Any other thoughts before I hit the commit button?
Nope that all sounds fine with me.
A commit references this bug:
Date: Wed Apr 26 12:37:31 UTC 2017
New revision: 439445
net-p2p/couchpotato: Port improvements
- Remove unnecessary libcurl and docbook-xml dependencies
- Add missing py-lxml and py-openssl dependencies for better performance
- Force python requirement to 2.7
- Add unrar as optional dependency
- Remove hardcoded user in rc script
- New MAINTAINER