Bug 218856 - devel/valgrind devel/valgrind-devel: Properly detect clang 5.0.0
Summary: devel/valgrind devel/valgrind-devel: Properly detect clang 5.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks: 219139
  Show dependency treegraph
 
Reported: 2017-04-24 19:55 UTC by Dimitry Andric
Modified: 2017-07-05 20:16 UTC (History)
1 user (show)

See Also:
bdrewery: maintainer-feedback+


Attachments
Fix clang 5 detection for valgrind (2.34 KB, patch)
2017-04-24 19:55 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer 2017-04-24 19:55:45 UTC
Created attachment 182055 [details]
Fix clang 5 detection for valgrind

I'm doing preliminary tests with clang 5.0.0 in the projects/clang500-import branch, and it turned out that devel/valgrind and devel/valgrind-devel fail to detect the version.  This is because of a case statement with:

      clang-2.9|clang-3.*|clang-4.*)

Here's a patch that adds clang-5.* for now (upstream might want to think about extending this to any correct numerical version).  It also drops the USE_GCC from the Makefiles, which is apparently something added by Baptiste to support FreeBSD 8, so it is no longer necessary.
Comment 1 Bryan Drewery freebsd_committer 2017-07-05 17:13:45 UTC
Approved, please commit
Comment 2 commit-hook freebsd_committer 2017-07-05 17:21:47 UTC
A commit references this bug:

Author: dim
Date: Wed Jul  5 17:20:57 UTC 2017
New revision: 445087
URL: https://svnweb.freebsd.org/changeset/ports/445087

Log:
  Detect clang 5.0.0 correctly, and drop USE_GCC.

  Approved by:	bdrewery (maintainer)
  PR:		218856
  MFH:		2017Q3

Changes:
  head/devel/valgrind/files/patch-configure.ac
  head/devel/valgrind-devel/files/patch-configure.ac
Comment 3 Jan Beich freebsd_committer 2017-07-05 18:25:48 UTC
USE_GCC hunk is missing from ports r445087, so the commit message is slightly confusing.
Comment 4 Dimitry Andric freebsd_committer 2017-07-05 20:16:48 UTC
(In reply to Jan Beich from comment #3)
> USE_GCC hunk is missing from ports r445087, so the commit message is
> slightly confusing.

Ah yeah sorry, that was already fixed in r440063 by bdrewery, some time ago.  I had that in my tree for ages, so I was sort of convinced it still needed to be done. :)