Updates to gtk3 and related ports broke games/aisleriot. Specifically, sol segfaults on startup. (gdb) bt #0 0x000000002d5850e8 in ?? () #1 0x00007fffffffd060 in ?? () #2 0x0000000000413302 in style_updated_cb (widget=0x0, style=0x0) at ar-style-gtk.c:295 Previous frame identical to this frame (corrupt stack?) Reverting 439206 allows it to run again. I suspect an update of aisleriot to a reasonably recent release will fix the problem.
(In reply to rkoberman from comment #0) Yes, I confirm that updating aisleriot to 3.20.1 fixes the problem. Changes: https://download.gnome.org/sources/aisleriot/3.20/aisleriot-3.20.1.changes
https://git.gnome.org//browse/aisleriot/ : => 2017-03-19 build: Build against guile 2.2 by default (I tried the update just for me to 3.22.1 with guile-2.0.14. It seems to work). But i don't know if it is needed to update guile.
There is an open ticket to update games/aisleriot to 3.22.1, and is assigned to gnome@. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216505. While it was opened, nothing appears to have been done with it. No patch to the Makefile, just a statement that the port is a bit out of date. It builds and runs on amd64 with only changing the version in the Makefile. Only tested on 11-STABLE (r317350).
I had an update patch. Shoud I attach it, or should I wait for the guile update and CC the maintainer of guile (or open update request for it)?
Opened an update request for guile2 Bug 218874.
(In reply to w.schwarzenfeld from comment #5) aisleriot can build against guile 2.0 or 2.2 (by default). https://github.com/GNOME/aisleriot/blob/master/configure.ac#L479
Created attachment 182083 [details] svn-diff-games_aisleriot I was not clear about boehm-gc-thread. I don't think it is really needed. So I commented out. portlint ok. Testbuilds with poudriere on 10.3-amd64/i386 ok. ChangeLog: s://git.gnome.org//browse/aisleriot/
Paiste error: https://git.gnome.org//browse/aisleriot/
This works correctly as is. My only question is whether boehm-gc-threaded is a dependency. The executable, sol, is linked to libgc-threaded which is provided by devel/boehm-gc-threaded, but looks like it is added by the staging process. Still, if the port is not installed, rtld will bail with a missing library. At least on my system devel/boehm-gc-threaded is depended on only by devel/boehm-gc and is linked in by stage-qa. (boehm-gc shows nothing depending on it, so it may not even belong here, but I don't believe that.) Any explanation would certainly be appreciated!
Created attachment 182464 [details] svn-diff-games_aisleriot
Forget to remove old portversion. Uncommented boehm-gc-threaded lib-depends.
*** Bug 216505 has been marked as a duplicate of this bug. ***
Created attachment 182519 [details] svn-diff-games_aisleriot_3_22_2 In the meantime a newer version 3.22.2 (from 7.5. 2017).
Hi, thanks for the report. I'm almost done "playing" in webkit land. After that I will tackle updating the games/utils!
A commit references this bug: Author: pi Date: Fri May 12 02:47:05 UTC 2017 New revision: 440673 URL: https://svnweb.freebsd.org/changeset/ports/440673 Log: games/aisleriot: update 3.18.2 -> 3.22.2 https://download.gnome.org/sources/aisleriot/3.20/aisleriot-3.20.0.changes https://download.gnome.org/sources/aisleriot/3.20/aisleriot-3.20.1.changes https://download.gnome.org/sources/aisleriot/3.20/aisleriot-3.20.2.changes https://download.gnome.org/sources/aisleriot/3.22/aisleriot-3.22.0.changes https://download.gnome.org/sources/aisleriot/3.22/aisleriot-3.22.1.changes https://download.gnome.org/sources/aisleriot/3.22/aisleriot-3.22.2.changes PR: 218862 Submitted by: w.schwarzenfeld@utanet.at Reported by: rkoberman@gmail.com Changes: head/games/aisleriot/Makefile head/games/aisleriot/distinfo head/games/aisleriot/pkg-plist
Committed, thanks!