Created attachment 182130 [details] patch to ezjail source The legacy rc.conf method is depreciated and support for it will be removed in an coming release of Freebsd. The /etc/rc.d/jail script contains the on-the-fly conversion from the legacy rc.conf method used by ezjail to the jail.conf method. This conversion code is what is planed to be removed. To negate the need of rewriting the ezjail-admin script to internally use the jail.conf method this simple hack is being used instead. The /etc/rc.d/jail script is copied to the ezjail port source, renamed ezjail.jail and the following line of code changed in the ezjail.sh script to use it instead of the OS one, so when the legacy rc.conf method is removed from the OS /etc/rc.d/jail script it will not effect ezjail operation. #[ "${ezjail_pass}" ] && sh /etc/rc.d/jail one${action%crypto} ${ezjail_pass} [ "${ezjail_pass}" ] && sh /usr/local/bin/ezjail.jail one${action%crypto} ${ezjail_pass}
Comment on attachment 182130 [details] patch to ezjail source I don't usually steal other people's code. This is not going to move to ezjail package. Also this patch messes with other scripts in ezjail's working dir.
I am at a lose to comprehend your use of "steal other people's code". Like all PRs this is offered free without any implied restrictions. Ezjail has a track record of applying submitted patches all the time. ezjail only has 2 scripts, This patch changes only a single line in the behind the scenes script. The main work horse ezjail-admin script is untouched. I do not see what other files in your current source you could possible be speaking of. This is a simple solution to address concerns brought up in PR #218849 which you posted to. My effort here is to give your port a simple way to keep from being marked as broken as voiced in PR #218849. Please describe more clearly your objections. Like all port maintainers, FreeBSD empowers you with the right to decline any and all patches to your port as you see fit. I respect that right.
The "ezjail.jail" code you asked me to commit is copied from FreeBSD's base system. It doesn't become less of "not my source", if you attach it as a "patch" to this PR. ezjail port is not marked broken and is not going to be marked in the near future. On a personal note: Don't you think it's enough that you have stolen my source code in 2011 without attribution and that you've been running around in all forums to convince FreeBSD users to use qjail over ezjail, spreading FUD? Now you even try to deliberately break ezjail by removing the base system's functions it relies on? Seriously, can't you just leave it be? What's wrong with you?
Being from the Philippines, new to FreeBSD and forking a port for the first time, I being a member of the original team who forked eajail, we were all unaware of the UN-documented rules about giving attribution to the original author of the port being forked. We just did not know that leaving it out was wrong. The team and I have repeatable proclaimed our error to you and the FreeBSD community and proceeded to give acknowledgment to you as the author of the forked port very prominently at the start of the qjail script and in the man pages. Now I see the style of script logic descriptive comments used in qjail has made its way into the ezjail-admin script and the man pages have even taken on the qjail use of descriptive detailing previous lacking in the ezjail man pages. I take comfort in the knowledge that who ever submitted the patch making those changes realized their benefits after reviewing the qjail script and man pages. I know this happened and don't care. I am bigger than that. I have put this old history behind me and now I try to give back in some small way to help you out and you throw this old history back in my face. You are the one who has not let bygones be bygones by bring this up again. Your action makes me very sorry that I ever tried to help you out. I don't need this aggravation. Life is to short for this kind of petty drama. You do realize that warning message is driving new ezjail users to search for alternate jail tools before committing to using ezjail. You have been around long enough to know you can use that OS jail script by adding attribution and referencing the BSD license. Enough is enough. I am closing this PR.