Created attachment 182247 [details] Patch devel/phpinit is only for PHP 56. For PHP 70, there is devel/phpunit6
It currently works with PHP 7.0 and PHP 7.1. (Didn't it?) So: is there any other reason for the ignore?
(In reply to Torsten Zuehlsdorff from comment #1) The release notes show that PHP 70 and PHP 71 are not supported. If it is, it is random.
(In reply to Jochen Neumeister from comment #2) > The release notes show that PHP 70 and PHP 71 are not supported. > If it is, it is random. That is right. But "not supported" is justified with "PHP 5.6 is no longer supported". Not with "it doesn't work". Also PHP 7.0 and 7.1 syntax, functions or semantics are very unlikely to change. So i'm hesitant to remove something working, which will work much longer, without another reason.
(In reply to Torsten Zuehlsdorff from comment #3) So we can remove this Port, ans use devel/phpunit6 for all PHP versions. There must then also be released for PHP56 (So, phpunit6 works with PHP56)
Not really. phpunit6 is under active development and therefore changes regularly. Therefore there is a high change to break PHP 5.6 support in the future. phpunit5 on the other side did not change. To break devel/phpunit we need an very unlikle API, Syntax or Semantik change in PHP - which is guaranteed not to happen until PHP 7.2. But we can remove phpunit5 when we finally bump our default PHP version to 7. :)
Okay, then we close the PR here
Done. :) Thanks for the patch and the discussion!