Bug 219119 - audio/sonic-visualiser: Use standard PULSEAUDIO option
Summary: audio/sonic-visualiser: Use standard PULSEAUDIO option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: https://reviews.freebsd.org/D10646
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-05-07 14:29 UTC by Tobias Kortkamp
Modified: 2017-05-09 09:22 UTC (History)
1 user (show)

See Also:
uddka: maintainer-feedback+
uddka: maintainer-feedback+

Attachments
sonic-visualiser.diff (1.15 KB, patch)
2017-05-07 14:29 UTC, Tobias Kortkamp 		uddka: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2017-05-07 14:29:07 UTC 
The vast majority of ports name the option to enable PulseAudio support
PULSEAUDIO.  sonic-visualiser currently uses PULSE.  Can we change it to
PULSEAUDIO for consistencies sake?

This also makes it easier for users to disable/enable PulseAudio accross the
ports tree via OPTIONS_SET=PULSEAUDIO in /etc/make.conf without having to
remember to also set PULSE.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2017-05-07 14:29:45 UTC 
Created attachment 182361 [details]
sonic-visualiser.diff
Comment 2 Christian Krämer 2017-05-08 11:48:34 UTC 
Sounds reasonable...
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2017-05-08 14:16:39 UTC 
Thank you.
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-05-09 09:21:07 UTC 
A commit references this bug:

Author: tobik
Date: Tue May  9 09:19:26 UTC 2017
New revision: 440476
URL: https://svnweb.freebsd.org/changeset/ports/440476

Log:
  Rename option PULSE to PULSEAUDIO

  Almost all other ports use PULSEAUDIO to enable PulseAudio support.  This
  makes it easier to enable support globally via OPTIONS_SET.

  PR:		219119
  Approved by:	lme (mentor), Christian Kraemer <uddka@student.kit.edu> (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D10646

Changes:
  head/audio/sonic-visualiser/Makefile