Created attachment 182589 [details] Proposed patch After r370199 | bapt | 2014-10-06 18:13:15 +0000 (Mon, 06 Oct 2014) | 5 lines Comment out info/dir files indexinfo is taking care of generating it at package installation time many ports such as the lang/gcc* family had entries such as @comment info/gcc%%SUFFIX%%/dir When I now removed this for lang/gcc5-devel (r439213), Scripts/check-stagedir.sh started to warn Error: Orphaned: info/gcc5/dir Looking into the script there already is whitelisting in place for these info's dir files in general, alas not for ports that need to use a subdirectory to avoid conflicts between different versions: # Handle whitelisting while read path; do case "${path}" in *.bak) ;; *.orig) ;; : */info/dir|info/dir) ;; This patch takes care of that. Okay?
Okay to commit, portmgr? To make it easier to approve, here is the patch directly as well: Index: Mk/Scripts/check-stagedir.sh =================================================================== --- Mk/Scripts/check-stagedir.sh (revision 440871) +++ Mk/Scripts/check-stagedir.sh (working copy) @@ -152,7 +152,7 @@ */.svn/*|'@dir '*/.svn) ;; */.svnignore) ;; */CVS/*|'@dir '*/CVS) ;; - */info/dir|info/dir) ;; + */info/dir|info/dir|info/*/dir) ;; share/fonts/*/fonts.dir) ;; share/fonts/*/fonts.scale) ;; share/applications/mimeinfo.cache) ;;
portmgr, did you have a chance to look into this? It's a really simply one-line patch which I'd be happy to apply with your approval. :-)
Ping. Okay to apply this trivial patch I submitted two months ago? (Bapt, by the way, these comments "@comment info/gcc%%SUFFIX%%/dir" do indicate that check-stagedir.sh is not working properly, is it?)
Comment on attachment 182589 [details] Proposed patch Maintainer timeout (2+ months)
Minor change, easily revertible with minimal potential impact. Reporter is committer, assign accordingly
There cannot, ever, be a maintainer timeout for portmgr@. See https://www.freebsd.org/doc/en/books/porters-handbook/makefile-maintainer.html.
That's why I did not invoke maintainer timeout here. That said, can portmgr@ please approve this? More than two months for a trivial, one line patch, is a little frustrating.
Well, it does need someone to understand the change, it seems innocent enough, but you never know what can lurk in the background. I'll say approved, because I really don't know what could go wrong here. In the future, ask for an exp-run, depending on the load, it can be done in a day or two. Once this is done, we are usually more open to accepting changes :-)
A commit references this bug: Author: gerald Date: Wed Jul 19 22:29:54 UTC 2017 New revision: 446238 URL: https://svnweb.freebsd.org/changeset/ports/446238 Log: Ignore info/*/dir (as used by the lang/gcc* ports, for example) in addition to */info/dir and info/dir. PR: 219274 Approved by: portmgr (mat) Changes: head/Mk/Scripts/check-stagedir.sh
(In reply to Mathieu Arnold from comment #8) > Well, it does need someone to understand the change bapt put in place workarounds for explicitly this issue, so I had hoped he might bite. ;-) Thanks for your help Mathieu! > In the future, ask for an exp-run, depending on the load, it can be done in a > day or two. Once this is done, we are usually more open to accepting changes :-) That is good guidance, thank you.
(Got approval from mat.)
A commit references this bug: Author: gerald Date: Wed Jul 19 22:41:58 UTC 2017 New revision: 446239 URL: https://svnweb.freebsd.org/changeset/ports/446239 Log: Remove workarounds for PR 219274 that bapt@ had put in place in 2014 from the end-of-life lang/gcc4* ports. PR: 219274 Changes: head/lang/gcc46/pkg-plist head/lang/gcc47/pkg-plist head/lang/gcc48/pkg-plist head/lang/gcc49/pkg-plist
A commit references this bug: Author: gerald Date: Fri Jul 21 10:53:43 UTC 2017 New revision: 446305 URL: https://svnweb.freebsd.org/changeset/ports/446305 Log: Update to the 20170621 snapshot of GCC 6.4.1, moving from GCC 6.3.1 now that GCC 6.4 has been released. Remove workaround for PR 219274 that bapt@ had put in place in 2014 from pkg-plist. PR: 219274 Changes: head/lang/gcc6-devel/Makefile head/lang/gcc6-devel/distinfo head/lang/gcc6-devel/pkg-plist
A commit references this bug: Author: gerald Date: Fri Jul 21 11:55:51 UTC 2017 New revision: 446309 URL: https://svnweb.freebsd.org/changeset/ports/446309 Log: Update to the 20170720 snapshot of GCC 7.1.1. Remove workaround for PR 219274 that bapt@ had put in place in 2014 from pkg-plist. [1] PR: 219274 [1] Changes: head/lang/gcc7-devel/Makefile head/lang/gcc7-devel/distinfo head/lang/gcc7-devel/pkg-plist
A commit references this bug: Author: gerald Date: Mon Jul 24 11:53:47 UTC 2017 New revision: 446521 URL: https://svnweb.freebsd.org/changeset/ports/446521 Log: Update to the 20170723 snapshot of GCC 8. Remove workaround for PR 219274 that bapt@ had put in place in 2014 from pkg-plist. [1] PR: 219274 [1] Changes: head/lang/gcc8-devel/Makefile head/lang/gcc8-devel/distinfo head/lang/gcc8-devel/pkg-plist
A commit references this bug: Author: gerald Date: Sun Aug 6 06:24:31 UTC 2017 New revision: 447444 URL: https://svnweb.freebsd.org/changeset/ports/447444 Log: Remove workaround for PR 219274 that bapt@ had put in place in 2014 from pkg-plist for lang/gcc5 and lang/gcc6 (which won't be updated too soon otherwise). PR: 219274 Changes: head/lang/gcc5/pkg-plist head/lang/gcc6/pkg-plist
MARKED AS SPAM