Bug 219323 - net/py-ldaptor: Limit to 2.x (Does not work with Python 3)
Summary: net/py-ldaptor: Limit to 2.x (Does not work with Python 3)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2017-05-16 10:18 UTC by Johannes Jost Meixner
Modified: 2017-08-19 10:51 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (nagy.attila)
koobs: merge-quarterly+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Jost Meixner freebsd_committer freebsd_triage 2017-05-16 10:18:05 UTC
net/py-ldaptor depends on twisted, which is python2 only.

===>   py36-ldaptor-0.0.43_1 depends on file: /usr/local/lib/python3.6/site-packages/twisted/__init__.py - not found

Please change USES= python to USES= python:2 and bump portversion.
Comment 1 Johannes Jost Meixner freebsd_committer freebsd_triage 2017-05-16 10:18:44 UTC
Is there a specific reason for this port having both pkg-plist *and* USE_PYTHON= autoplist?
Comment 2 Johannes Jost Meixner freebsd_committer freebsd_triage 2017-07-28 04:18:15 UTC
Throw back into bugs pool
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-19 09:52:59 UTC
Twisted supports Python 3.x as of a number of versions ago, for some growing number of its components, and on initial view ldaptor appears inconsistent (at least not explicit) in its state of Python 3.x support:

- A Python 3 compatible wheel is available on PyPI
- Python 3.3-3.5 are included in tox.ini for testing
- Travis CI configuration only tests with 2.7
- Open "Python3 support #55" upstream issue [1]

[1] https://github.com/twisted/ldaptor/issues/55

I also note that the ldaptor port:

- Is outdated (0.0.43 -> 16.0.0)
- MASTER_SITES/DISTFILES are 404
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-19 10:05:18 UTC
The port uses pkg-plist to list (locale) files installed that are not referenced in the distutils/setuptools --record output file, which autoplist uses. This is likely due to custom build/install commands in setup.py that override, bypass or otherwise mangle that functionality
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-08-19 10:43:40 UTC
A commit references this bug:

Author: koobs
Date: Sat Aug 19 10:43:07 UTC 2017
New revision: 448296
URL: https://svnweb.freebsd.org/changeset/ports/448296

Log:
  net/py-ldaptor: Limit to 2.7 (Does not support Python 3.x)

  This port depends on Twisted, which supports Python 3.x as of a number of
  versions ago for some growing number of its components. On initial view, ldaptor
  appears inconsistent (at least not explicit) in its state of Python 3.x support
  for its latest version (16.0.0, not this ports version, 0.0.43)

  - A Python 3 compatible wheel is available on PyPI
  - Python 3.3-3.5 are included in tox.ini for testing

  However:

  - Travis CI configuration only tests with 2.7
  - Open "Python3 support #55" upstream issue [1]

  Additionally, Twisted/Python3 support aside, test builds (without USES=twisted
  declared), results in a build error at configure time:

    SyntaxError: invalid syntax

  This change limits build support to Python 2.7 accordingly.

  While I'm here:

  - Pet portlint: LICENSE [2], PLIST_FILES, makepatch.

  [1] https://github.com/twisted/ldaptor/issues/55
  [2] https://github.com/twisted/ldaptor/commit/7e249b1586789a5c588f662ce74ee9f4338666e0

  PR:		219323
  Reported by:	Johannes Jost Meixner
  Approved by:	portmgr (blanket)
  MFH:		2017Q3

Changes:
  head/net/py-ldaptor/Makefile
  head/net/py-ldaptor/files/patch-setup.py
  head/net/py-ldaptor/pkg-plist
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-08-19 10:47:45 UTC
A commit references this bug:

Author: koobs
Date: Sat Aug 19 10:47:21 UTC 2017
New revision: 448297
URL: https://svnweb.freebsd.org/changeset/ports/448297

Log:
  MFH: r448296

  net/py-ldaptor: Limit to 2.7 (Does not support Python 3.x)

  This port depends on Twisted, which supports Python 3.x as of a number of
  versions ago for some growing number of its components. On initial view, ldaptor
  appears inconsistent (at least not explicit) in its state of Python 3.x support
  for its latest version (16.0.0, not this ports version, 0.0.43)

  - A Python 3 compatible wheel is available on PyPI
  - Python 3.3-3.5 are included in tox.ini for testing

  However:

  - Travis CI configuration only tests with 2.7
  - Open "Python3 support #55" upstream issue [1]

  Additionally, Twisted/Python3 support aside, test builds (without USES=twisted
  declared), results in a build error at configure time:

    SyntaxError: invalid syntax

  This change limits build support to Python 2.7 accordingly.

  While I'm here:

  - Pet portlint: LICENSE [2], PLIST_FILES, makepatch.

  [1] https://github.com/twisted/ldaptor/issues/55
  [2] https://github.com/twisted/ldaptor/commit/7e249b1586789a5c588f662ce74ee9f4338666e0

  PR:		219323
  Reported by:	Johannes Jost Meixner
  Approved by:	portmgr (blanket)

  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2017Q3/
  branches/2017Q3/net/py-ldaptor/Makefile
  branches/2017Q3/net/py-ldaptor/files/patch-setup.py
  branches/2017Q3/net/py-ldaptor/pkg-plist
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-19 10:51:55 UTC
Committed and merged, thank you for your report Johannes. Of note, python:2 use is only valid for those (upstream) Python packages that depend on a LOCALBASE/bin/python2 symlink. It does not mean 'supports any versions of Python 2.*'