Bug 219495 - www/webkit2-gtk3: fails to build on armv6
Summary: www/webkit2-gtk3: fails to build on armv6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Many People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-24 07:05 UTC by Mikael Urankar
Modified: 2017-05-27 07:15 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)

Attachments
patch (994 bytes, patch)
2017-05-24 07:05 UTC, Mikael Urankar 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2017-05-24 07:05:37 UTC 
Created attachment 182852 [details]
patch

Source/bmalloc/bmalloc/BPlatform.h:180:9: warning: 'BARM_ARCH_VERSION' is not defined, evaluates to 0 [-Wundef]
#  elif BARM_ARCH_AT_LEAST(4)
        ^
Source/bmalloc/bmalloc/BPlatform.h:84:45: note: expanded from macro 'BARM_ARCH_AT_LEAST'
#define BARM_ARCH_AT_LEAST(N) (BCPU(ARM) && BARM_ARCH_VERSION >= N)
                                            ^
Source/bmalloc/bmalloc/BPlatform.h:184:6: error: "Not supported ARM architecture"
#    error "Not supported ARM architecture"
     ^
1 warning and 1 error generated.
ninja: build stopped: subcommand failed.

The attached patch is a potential fix (untested)

reported by: bob prohaska
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2017-05-26 10:57:17 UTC 
I can successfully build the port with the attached patch.
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-05-27 07:14:48 UTC 
A commit references this bug:

Author: kwm
Date: Sat May 27 07:14:31 UTC 2017
New revision: 441828
URL: https://svnweb.freebsd.org/changeset/ports/441828

Log:
  Update webkit2-gtk3 to 2.16.3.

  * Fix the build when using port compile and binutils is installed. It
    seems Cmake picks up ar and ranlib from localbase when using a compiler
    from ports, but the compiler uses ld from base for linking. Base ld
    doesn't understand some features newer ar and ranlib from localbase
    are using. So tell the build to always use ar and ranlib from base. [1]
  * Fix build failure on armv6 [2]

  PR:		219161 [1], 219495 [2]
  Submitted by:	mikael.urankar@gmail.com [2]

Changes:
  head/www/webkit2-gtk3/Makefile
  head/www/webkit2-gtk3/distinfo
  head/www/webkit2-gtk3/files/patch-Source_bmalloc_bmalloc_BPlatform.h
  head/www/webkit2-gtk3/pkg-plist