Bug 219604 - devel/libphutil: [patch] The fallback editor is not in the base system
Summary: devel/libphutil: [patch] The fallback editor is not in the base system
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Michael Gmelin
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-05-27 21:48 UTC by kd-dev
Modified: 2017-06-20 00:50 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (grembo)

Attachments
Replace the hard-coded fallback editors with vi(1) (1.36 KB, patch)
2017-05-27 21:48 UTC, kd-dev 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kd-dev 2017-05-27 21:48:54 UTC 
Created attachment 182976 [details]
Replace the hard-coded fallback editors with vi(1)

If `PhutilInteractiveEditor' is not configured with a preferred
editor, and the EDITOR environment variable is unset, it attempts
to fallback to using `nano' (editors/nano) producing an error if it
is not installed.

How-To-Repeat: (using devel/arcanist)
$ arc diff --create <path>
Exception
Unable to launch an interactive text editor. Set the EDITOR environment
variable to an appropriate editor.
(Run with `--trace` for a full exception trace.)

Fix:
The attached fix adds a patch to the port's files that replaces the
hard-coded fallback editor with vi(1).
Comment 1 Michael Gmelin freebsd_committer freebsd_triage 2017-06-19 10:27:02 UTC 
(In reply to kdrakehp from comment #0)

Don't you think it would make more sense to get that patch into upstream?
Comment 2 kd-dev 2017-06-20 00:50:34 UTC 
You are right, I talked to upstream and it has been fixed.(In reply to Michael Gmelin from comment #1)